Move GeolocationClient to the Oilpan heap.

Source/web/WebLocalFrameImpl.cpp

Index: Source/web/WebLocalFrameImpl.cpp
diff --git a/Source/web/WebLocalFrameImpl.cpp b/Source/web/WebLocalFrameImpl.cpp
index 698e1e5500f359736dc416355238e74606fda96d..27ba6f57b7a69d953fbfb027dafa33d2f2dbab16 100644
--- a/Source/web/WebLocalFrameImpl.cpp
+++ b/Source/web/WebLocalFrameImpl.cpp
@@ -497,14 +497,6 @@ void WebLocalFrameImpl::close()
 {
     m_client = 0;
 
-    // FIXME: Oilpan: Signal to LocalFrame and its supplements that the frame is
-    // being torn down so it can do prompt clean-up. For example, this will
-    // clear the raw back pointer to m_geolocationClientProxy. Once
-    // GeolocationClientProxy is on-heap it looks like we can completely remove
-    // |willBeDestroyed| from supplements since tracing will ensure safety.
-    if (m_frame)
-        m_frame->willBeDestroyed();

[sof, 2014/08/21 13:31:17]

We've been looking into why this notification was here and why it is safe to
remove it.

The embedder calls close() to delete the frame, and will do this last thing.
Hence, sending a notification back that the geolocation controller is going away
is redundant. The embedder will not touch the geolocation client via its
dispatcher afterwards.

There are/were no other supplement overrides of willBeDestroyed() besides for
GeolocationController, hence this removal is safe. The geolocationDestroyed()
call can be retired in a followup.

-
     deref(); // Balances ref() acquired in WebFrame::create
 }
 
@@ -1529,7 +1521,7 @@ WebLocalFrameImpl::WebLocalFrameImpl(WebFrameClient* client)
     , m_permissionClient(0)
     , m_inputEventsScaleFactorForEmulation(1)
     , m_userMediaClientImpl(this)
-    , m_geolocationClientProxy(adoptPtr(new GeolocationClientProxy(client ? client->geolocationClient() : 0)))
+    , m_geolocationClientProxy(GeolocationClientProxy::create(client ? client->geolocationClient() : 0))
 {
     Platform::current()->incrementStatsCounter(webFrameActiveCount);
     frameCount++;