Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(268)

Side by Side Diff: Source/modules/geolocation/GeolocationClient.h

Issue 490143002: Move GeolocationClient to the Oilpan heap. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2009 Apple Inc. All rights reserved. 2 * Copyright (C) 2009 Apple Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
11 * documentation and/or other materials provided with the distribution. 11 * documentation and/or other materials provided with the distribution.
12 * 12 *
13 * THIS SOFTWARE IS PROVIDED BY APPLE INC. AND ITS CONTRIBUTORS ``AS IS'' 13 * THIS SOFTWARE IS PROVIDED BY APPLE INC. AND ITS CONTRIBUTORS ``AS IS''
14 * AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, 14 * AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO,
15 * THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR 15 * THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR
16 * PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL APPLE INC. OR ITS CONTRIBUTORS 16 * PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL APPLE INC. OR ITS CONTRIBUTORS
17 * BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR 17 * BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR
18 * CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF 18 * CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF
19 * SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS 19 * SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS
20 * INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN 20 * INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN
21 * CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) 21 * CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)
22 * ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF 22 * ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF
23 * THE POSSIBILITY OF SUCH DAMAGE. 23 * THE POSSIBILITY OF SUCH DAMAGE.
24 */ 24 */
25 25
26 #ifndef GeolocationClient_h 26 #ifndef GeolocationClient_h
27 #define GeolocationClient_h 27 #define GeolocationClient_h
28 28
29 #include "platform/heap/Handle.h"
30
29 namespace blink { 31 namespace blink {
30 32
31 class Geolocation; 33 class Geolocation;
32 class GeolocationController; 34 class GeolocationController;
33 class GeolocationPosition; 35 class GeolocationPosition;
34 class LocalFrame; 36 class LocalFrame;
35 37
36 class GeolocationClient { 38 class GeolocationClient : public NoBaseWillBeGarbageCollectedFinalized<Geolocati onClient> {
sof 2014/08/21 09:43:41 It is arguably moot to insist on *Finalized here (
37 public: 39 public:
38 virtual void geolocationDestroyed() = 0; 40 virtual ~GeolocationClient() { }
sof 2014/08/21 09:43:42 If this CL goes ahead, geolocationDestroyed() can
39 41
40 virtual void startUpdating() = 0; 42 virtual void startUpdating() = 0;
41 virtual void stopUpdating() = 0; 43 virtual void stopUpdating() = 0;
42 virtual void setEnableHighAccuracy(bool) = 0; 44 virtual void setEnableHighAccuracy(bool) = 0;
43 virtual GeolocationPosition* lastPosition() = 0; 45 virtual GeolocationPosition* lastPosition() = 0;
44 46
45 virtual void requestPermission(Geolocation*) = 0; 47 virtual void requestPermission(Geolocation*) = 0;
46 virtual void cancelPermissionRequest(Geolocation*) = 0; 48 virtual void cancelPermissionRequest(Geolocation*) = 0;
47 49
48 virtual void controllerForTestAdded(GeolocationController*) { } 50 virtual void controllerForTestAdded(GeolocationController*) { }
49 virtual void controllerForTestRemoved(GeolocationController*) { } 51 virtual void controllerForTestRemoved(GeolocationController*) { }
50 52
51 protected: 53 virtual void trace(Visitor*) { }
52 virtual ~GeolocationClient() { }
53 }; 54 };
54 55
55 void provideGeolocationTo(LocalFrame&, GeolocationClient*); 56 void provideGeolocationTo(LocalFrame&, GeolocationClient*);
56 57
57 } // namespace blink 58 } // namespace blink
58 59
59 #endif // GeolocationClient_h 60 #endif // GeolocationClient_h
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698