Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(110)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 483683005: Move IC code into a subdir and move ic-compilation related code from stub-cache into ic-compiler (Closed)

Created:
6 years, 4 months ago by Toon Verwaest
Modified:
6 years, 4 months ago
Reviewers:
Benedikt Meurer, Yang
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Move IC code into a subdir and move ic-compilation related code from stub-cache into ic-compiler BUG= R=bmeurer@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=23306

Patch Set 1 #

Patch Set 2 : Ports #

Patch Set 3 : Fix BUILD.gn #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2143 lines, -18526 lines) Patch
M BUILD.gn View 1 2 10 chunks +17 lines, -13 lines 0 comments Download
M src/arm/builtins-arm.cc View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M src/arm/code-stubs-arm.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M src/arm/code-stubs-arm.cc View 1 2 1 chunk +5 lines, -1 line 0 comments Download
M src/arm/codegen-arm.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M src/arm/full-codegen-arm.cc View 1 2 1 chunk +0 lines, -1 line 0 comments Download
D src/arm/ic-arm.cc View 2 1 chunk +0 lines, -1242 lines 0 comments Download
M src/arm/lithium-codegen-arm.cc View 1 2 1 chunk +0 lines, -1 line 0 comments Download
D src/arm/stub-cache-arm.cc View 2 1 chunk +0 lines, -1172 lines 0 comments Download
M src/arm64/builtins-arm64.cc View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M src/arm64/code-stubs-arm64.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M src/arm64/code-stubs-arm64.cc View 1 2 1 chunk +5 lines, -1 line 0 comments Download
M src/arm64/codegen-arm64.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M src/arm64/full-codegen-arm64.cc View 1 2 1 chunk +0 lines, -1 line 0 comments Download
D src/arm64/ic-arm64.cc View 2 1 chunk +0 lines, -1287 lines 0 comments Download
M src/arm64/lithium-codegen-arm64.cc View 1 2 1 chunk +0 lines, -1 line 0 comments Download
D src/arm64/stub-cache-arm64.cc View 2 1 chunk +0 lines, -1141 lines 0 comments Download
M src/assembler.cc View 2 1 chunk +3 lines, -2 lines 0 comments Download
M src/builtins.cc View 2 1 chunk +2 lines, -2 lines 0 comments Download
M src/code-stubs.h View 2 1 chunk +1 line, -0 lines 0 comments Download
M src/code-stubs.cc View 2 1 chunk +1 line, -1 line 0 comments Download
M src/codegen.cc View 2 1 chunk +0 lines, -1 line 0 comments Download
M src/debug.cc View 2 1 chunk +0 lines, -3 lines 0 comments Download
M src/full-codegen.cc View 2 1 chunk +0 lines, -1 line 0 comments Download
M src/heap/mark-compact.cc View 2 1 chunk +1 line, -2 lines 0 comments Download
M src/heap/objects-visiting.cc View 2 1 chunk +0 lines, -1 line 0 comments Download
M src/hydrogen.cc View 2 1 chunk +4 lines, -1 line 0 comments Download
M src/ia32/builtins-ia32.cc View 2 1 chunk +0 lines, -1 line 0 comments Download
M src/ia32/code-stubs-ia32.h View 1 2 1 chunk +1 line, -2 lines 0 comments Download
M src/ia32/code-stubs-ia32.cc View 2 1 chunk +1 line, -1 line 0 comments Download
M src/ia32/codegen-ia32.h View 2 1 chunk +1 line, -1 line 0 comments Download
M src/ia32/full-codegen-ia32.cc View 2 1 chunk +0 lines, -1 line 0 comments Download
D src/ia32/ic-ia32.cc View 2 1 chunk +0 lines, -1211 lines 0 comments Download
M src/ia32/lithium-codegen-ia32.cc View 2 1 chunk +0 lines, -2 lines 0 comments Download
D src/ia32/stub-cache-ia32.cc View 2 1 chunk +0 lines, -1187 lines 0 comments Download
D src/ic.h View 2 1 chunk +0 lines, -1033 lines 0 comments Download
D src/ic.cc View 2 1 chunk +0 lines, -3091 lines 0 comments Download
D src/ic-inl.h View 2 1 chunk +0 lines, -189 lines 0 comments Download
A + src/ic/arm/ic-arm.cc View 1 2 34 chunks +89 lines, -157 lines 0 comments Download
A + src/ic/arm/ic-compiler-arm.cc View 1 2 20 chunks +35 lines, -236 lines 0 comments Download
A src/ic/arm/stub-cache-arm.cc View 1 2 1 chunk +173 lines, -0 lines 0 comments Download
A + src/ic/arm64/ic-arm64.cc View 1 2 38 chunks +113 lines, -193 lines 0 comments Download
A + src/ic/arm64/ic-compiler-arm64.cc View 1 2 18 chunks +37 lines, -197 lines 0 comments Download
A src/ic/arm64/stub-cache-arm64.cc View 1 2 1 chunk +146 lines, -0 lines 0 comments Download
A + src/ic/ia32/ic-compiler-ia32.cc View 2 21 chunks +37 lines, -238 lines 0 comments Download
A + src/ic/ia32/ic-ia32.cc View 2 32 chunks +80 lines, -144 lines 0 comments Download
A src/ic/ia32/stub-cache-ia32.cc View 2 1 chunk +183 lines, -0 lines 0 comments Download
A + src/ic/ic.h View 2 40 chunks +98 lines, -167 lines 0 comments Download
A + src/ic/ic.cc View 2 61 chunks +367 lines, -259 lines 0 comments Download
A + src/ic/ic-compiler.h View 2 7 chunks +18 lines, -206 lines 0 comments Download
A + src/ic/ic-compiler.cc View 2 16 chunks +38 lines, -354 lines 0 comments Download
A + src/ic/ic-inl.h View 2 6 chunks +48 lines, -8 lines 0 comments Download
A src/ic/stub-cache.h View 2 1 chunk +168 lines, -0 lines 0 comments Download
A src/ic/stub-cache.cc View 2 1 chunk +146 lines, -0 lines 0 comments Download
A + src/ic/x64/ic-compiler-x64.cc View 1 2 25 chunks +41 lines, -200 lines 0 comments Download
A + src/ic/x64/ic-x64.cc View 1 2 42 chunks +99 lines, -182 lines 0 comments Download
A src/ic/x64/stub-cache-x64.cc View 1 2 1 chunk +149 lines, -0 lines 0 comments Download
M src/isolate.cc View 2 2 chunks +1 line, -1 line 0 comments Download
M src/runtime.cc View 2 1 chunk +0 lines, -1 line 0 comments Download
M src/serialize.cc View 2 1 chunk +2 lines, -2 lines 0 comments Download
D src/stub-cache.h View 2 1 chunk +0 lines, -683 lines 0 comments Download
D src/stub-cache.cc View 2 1 chunk +0 lines, -1299 lines 0 comments Download
M src/type-info.cc View 2 1 chunk +1 line, -3 lines 0 comments Download
M src/x64/builtins-x64.cc View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M src/x64/code-stubs-x64.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M src/x64/code-stubs-x64.cc View 1 2 1 chunk +4 lines, -1 line 0 comments Download
M src/x64/codegen-x64.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M src/x64/full-codegen-x64.cc View 1 2 1 chunk +0 lines, -1 line 0 comments Download
D src/x64/ic-x64.cc View 2 1 chunk +0 lines, -1237 lines 0 comments Download
M src/x64/lithium-codegen-x64.cc View 1 2 1 chunk +0 lines, -1 line 0 comments Download
D src/x64/stub-cache-x64.cc View 2 1 chunk +0 lines, -1134 lines 0 comments Download
M test/cctest/test-debug.cc View 2 1 chunk +0 lines, -1 line 0 comments Download
M test/cctest/test-deoptimization.cc View 2 1 chunk +0 lines, -1 line 0 comments Download
M test/cctest/test-disasm-ia32.cc View 2 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/test-disasm-x64.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/test-heap.cc View 2 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/test-serialize.cc View 2 1 chunk +0 lines, -1 line 0 comments Download
M tools/gyp/v8.gyp View 2 10 chunks +19 lines, -13 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Toon Verwaest
PTAL
6 years, 4 months ago (2014-08-22 10:34:45 UTC) #1
Benedikt Meurer
LGTM (rubber-stamped)
6 years, 4 months ago (2014-08-22 10:47:29 UTC) #2
Toon Verwaest
6 years, 4 months ago (2014-08-22 11:44:29 UTC) #3
Message was sent while issue was closed. 
Committed patchset #3 manually as 23306 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698