Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(119)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 481443002: Add GrResourceCache2. (Closed)

Created:
6 years, 4 months ago by bsalomon
Modified:
6 years, 4 months ago
Reviewers:
mtklein, robertphillips
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

Add GrResourceCache2. Currently it just replaces GrGpu as the owner of the linked list of resources. Committed: https://skia.googlesource.com/skia/+/94ce9ac8624dbb45656b8f5c992fad9c9ff3ee5f Committed: https://skia.googlesource.com/skia/+/c8dc1f74b6cdda9a43a638292a608c59c1d72d80

Patch Set 1 #

Patch Set 2 : Update comments #

Total comments: 2

Patch Set 3 : remove removeHead #

Total comments: 8

Patch Set 4 : Address comments #

Patch Set 5 : fix leaks #

Unified diffs Side-by-side diffs Delta from patch set Stats (+167 lines, -118 lines) Patch
M gyp/gpu.gypi View 1 2 3 4 1 chunk +2 lines, -0 lines 0 comments Download
M include/gpu/GrContext.h View 3 chunks +3 lines, -0 lines 0 comments Download
M include/gpu/GrGpuResource.h View 1 2 3 2 chunks +6 lines, -4 lines 0 comments Download
M src/gpu/GrClipMaskCache.h View 1 2 3 3 chunks +5 lines, -3 lines 0 comments Download
M src/gpu/GrClipMaskManager.h View 1 chunk +5 lines, -1 line 0 comments Download
M src/gpu/GrClipMaskManager.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M src/gpu/GrContext.cpp View 1 2 3 4 8 chunks +20 lines, -6 lines 0 comments Download
M src/gpu/GrGpu.h View 1 2 3 4 5 chunks +7 lines, -29 lines 0 comments Download
M src/gpu/GrGpu.cpp View 1 2 3 4 3 chunks +3 lines, -49 lines 0 comments Download
M src/gpu/GrGpuResource.cpp View 3 chunks +13 lines, -5 lines 0 comments Download
M src/gpu/GrLayerCache.cpp View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/GrResourceCache.cpp View 1 chunk +1 line, -1 line 0 comments Download
A src/gpu/GrResourceCache2.h View 1 2 3 1 chunk +40 lines, -0 lines 0 comments Download
A src/gpu/GrResourceCache2.cpp View 1 chunk +47 lines, -0 lines 0 comments Download
M src/gpu/gl/GrGpuGL.h View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download
M src/gpu/gl/GrGpuGL.cpp View 1 2 3 4 1 chunk +10 lines, -4 lines 0 comments Download
M src/gpu/gl/GrGpuGL_program.cpp View 1 2 3 4 1 chunk +0 lines, -11 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
bsalomon
Fresh start
6 years, 4 months ago (2014-08-15 15:53:22 UTC) #1
mtklein
https://codereview.chromium.org/481443002/diff/20001/include/core/SkTInternalLList.h File include/core/SkTInternalLList.h (right): https://codereview.chromium.org/481443002/diff/20001/include/core/SkTInternalLList.h#newcode76 include/core/SkTInternalLList.h:76: SkASSERT(NULL = fHead->fPrev); " NULL = " ಠ_ಠ
6 years, 4 months ago (2014-08-15 16:02:43 UTC) #2
bsalomon
On 2014/08/15 at 16:02:43, mtklein wrote: > https://codereview.chromium.org/481443002/diff/20001/include/core/SkTInternalLList.h > File include/core/SkTInternalLList.h (right): > > https://codereview.chromium.org/481443002/diff/20001/include/core/SkTInternalLList.h#newcode76 ...
6 years, 4 months ago (2014-08-15 16:11:21 UTC) #3
robertphillips
lgtm + some nits/suggestions https://codereview.chromium.org/481443002/diff/40001/include/gpu/GrContext.h File include/gpu/GrContext.h (right): https://codereview.chromium.org/481443002/diff/40001/include/gpu/GrContext.h#newcode977 include/gpu/GrContext.h:977: GrResourceCache* fResourceCache; SkAutoTDelete ? https://codereview.chromium.org/481443002/diff/40001/include/gpu/GrGpuResource.h ...
6 years, 4 months ago (2014-08-15 19:36:17 UTC) #4
bsalomon
The CQ bit was checked by bsalomon@google.com
6 years, 4 months ago (2014-08-19 15:13:40 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/bsalomon@google.com/481443002/60001
6 years, 4 months ago (2014-08-19 15:14:10 UTC) #6
bsalomon
https://codereview.chromium.org/481443002/diff/20001/include/core/SkTInternalLList.h File include/core/SkTInternalLList.h (right): https://codereview.chromium.org/481443002/diff/20001/include/core/SkTInternalLList.h#newcode76 include/core/SkTInternalLList.h:76: SkASSERT(NULL = fHead->fPrev); On 2014/08/15 16:02:43, mtklein wrote: > ...
6 years, 4 months ago (2014-08-19 15:16:09 UTC) #7
commit-bot: I haz the power
Committed patchset #4 (60001) as 94ce9ac8624dbb45656b8f5c992fad9c9ff3ee5f
6 years, 4 months ago (2014-08-19 15:21:29 UTC) #8
bsalomon
6 years, 4 months ago (2014-08-19 15:22:05 UTC) #9
bsalomon
A revert of this CL (patchset #4) has been created in https://codereview.chromium.org/477323006/ by bsalomon@google.com. The ...
6 years, 4 months ago (2014-08-19 21:20:20 UTC) #10
bsalomon
The CQ bit was checked by bsalomon@google.com
6 years, 4 months ago (2014-08-21 19:33:21 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/bsalomon@google.com/481443002/80001
6 years, 4 months ago (2014-08-21 19:33:49 UTC) #12
commit-bot: I haz the power
6 years, 4 months ago (2014-08-21 20:02:22 UTC) #13
Message was sent while issue was closed. 
Committed patchset #5 (80001) as c8dc1f74b6cdda9a43a638292a608c59c1d72d80

Powered by Google App Engine
This is Rietveld 408576698