Issue 477323006: Revert of Add GrResourceCache2.

Issue 477323006: Revert of Add GrResourceCache2. (Closed)

Created:
6 years, 4 months ago by bsalomon

Modified:
6 years, 4 months ago

Reviewers:
mtklein, robertphillips

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@master

Visibility:
Public.

Revert of Add GrResourceCache2. (patchset #4 of https://codereview.chromium.org/481443002/) Reason for revert: Likely caused a leak detected in Chromium after last Skia roll. Original issue's description: > Add GrResourceCache2. > > Currently it just replaces GrGpu as the owner of the linked list of resources. > > Committed: https://skia.googlesource.com/skia/+/94ce9ac8624dbb45656b8f5c992fad9c9ff3ee5f TBR=mtklein@google.com,robertphillips@google.com NOTREECHECKS=true NOTRY=true Committed: https://skia.googlesource.com/skia/+/1d89ddc4a3aad153501cfdc93bc1d61eb49157f4

Created: 6 years, 4 months ago

(Patch set is too large to download)

	Unified diffs	Side-by-side diffs	Stats (+126 lines, -163 lines)			Patch
M	gyp/gpu.gypi	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	include/gpu/GrContext.h	View	3 chunks	+0 lines, -3 lines	0 comments	Download
M	include/gpu/GrGpuResource.h	View	2 chunks	+4 lines, -6 lines	0 comments	Download
M	src/gpu/GrClipMaskCache.h	View	3 chunks	+3 lines, -5 lines	0 comments	Download
M	src/gpu/GrClipMaskManager.h	View	1 chunk	+1 line, -5 lines	0 comments	Download
M	src/gpu/GrClipMaskManager.cpp	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	src/gpu/GrContext.cpp	View	8 chunks	+6 lines, -15 lines	0 comments	Download
M	src/gpu/GrGpu.h	View	5 chunks	+29 lines, -7 lines	0 comments	Download
M	src/gpu/GrGpu.cpp	View	2 chunks	+57 lines, -5 lines	0 comments	Download
M	src/gpu/GrGpuResource.cpp	View	3 chunks	+5 lines, -13 lines	0 comments	Download
M	src/gpu/GrLayerCache.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/gpu/GrResourceCache.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
D	src/gpu/GrResourceCache2.h	View	1 chunk	+0 lines, -40 lines	0 comments	Download
D	src/gpu/GrResourceCache2.cpp	View	1 chunk	+0 lines, -47 lines	0 comments	Download
M	src/gpu/gl/GrGLPathRendering.cpp	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/gpu/gl/GrGpuGL.h	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	src/gpu/gl/GrGpuGL.cpp	View	1 chunk	+3 lines, -9 lines	0 comments	Download
M	src/gpu/gl/GrGpuGL_program.cpp	View	1 chunk	+11 lines, -0 lines	0 comments	Download

Total messages: 3 (0 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/bsalomon@google.com/477323006/1

6 years, 4 months ago (2014-08-19 21:20:46 UTC) #2

commit-bot: I haz the power

6 years, 4 months ago (2014-08-19 21:21:06 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (1) as 1d89ddc4a3aad153501cfdc93bc1d61eb49157f4