IDL: Set dictionary default values in impl constructor

IDL: Set dictionary default values in impl constructor

The current implementation sets default values in
V8T::toNative(). However, there are some code paths in which
we don't call V8T::toNative(). For example, if an IDL dictionary
is an optional argument and it isn't given, the binding layer
creates impl class by calling T::create() and passes it to
blink without calling V8T::toNative(). Since all dictionary impl
class instances should have default values, we should sets
default values in impl constructor.

BUG=321462
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=180384

[bashi, 2014-08-15 16:39:39]

Haraken-san, Jens,

Could you take a look?

I'm writing a CL[1] which adds the first IDL dictionary in core and noticed that
I should set default values in impl constructor classed, not in toNative().

I'll add a layout test case after [2] is landed.

[1] https://codereview.chromium.org/481453003/
[2] https://codereview.chromium.org/429853002/

https://codereview.chromium.org/479563003/diff/1/Source/bindings/templates/di...
File Source/bindings/templates/dictionary_impl.h (right):

https://codereview.chromium.org/479563003/diff/1/Source/bindings/templates/di...
Source/bindings/templates/dictionary_impl.h:26: void
{{member.setter_name}}({{member.rvalue_cpp_type}} value) { m_{{member.name}} =
value; }
small style correction.

[Jens Widell, 2014-08-15 16:49:19]

LGTM

[bashi, 2014-08-15 16:52:09]

On 2014/08/15 16:49:19, Jens Widell wrote:
> LGTM

Thanks!

[bashi, 2014-08-15 16:52:13]

The CQ bit was checked by bashi@chromium.org

[commit-bot: I haz the power, 2014-08-15 16:52:26]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/bashi@chromium.org/479563003/1

[commit-bot: I haz the power, 2014-08-15 17:31:17]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  win_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/22965)
  mac_gpu_triggered_tests on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu_triggered...)

[commit-bot: I haz the power, 2014-08-15 18:18:49]

Committed patchset #1 (1) as 180384

[haraken, 2014-08-15 22:29:38]

LGTM