Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(328)

Unified Diff: Source/bindings/templates/dictionary_v8.cpp

Issue 479563003: IDL: Set dictionary default values in impl constructor (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/bindings/templates/dictionary_v8.cpp
diff --git a/Source/bindings/templates/dictionary_v8.cpp b/Source/bindings/templates/dictionary_v8.cpp
index 7a1bce9cf6916bd8afea9fe97ac5107117ec2d9b..76240ac35cc94f2477e15d0090d640b11683ce5b 100644
--- a/Source/bindings/templates/dictionary_v8.cpp
+++ b/Source/bindings/templates/dictionary_v8.cpp
@@ -23,10 +23,6 @@ namespace blink {
{{member.cpp_type}} {{member.name}};
if (DictionaryHelper::get(dictionary, "{{member.name}}", {{member.name}}))
impl->{{member.setter_name}}({{member.name}});
- {% if member.cpp_default_value %}
- else
- impl->{{member.setter_name}}({{member.cpp_default_value}});
- {% endif %}
{% endfor %}
return impl;
}

Powered by Google App Engine
This is Rietveld 408576698