Source/bindings/templates/dictionary_impl.h - Issue 479563003: IDL: Set dictionary default values in impl constructor

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/templates/dictionary_impl.h

Issue 479563003: IDL: Set dictionary default values in impl constructor (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/bindings/templates/dictionary_impl.h

diff --git a/Source/bindings/templates/dictionary_impl.h b/Source/bindings/templates/dictionary_impl.h

index 491159ca8eced910248a79dca4fe7c1c1fe1121b..8e2364f8634cd5bb3b76dfeb137fc83a5a0b25a2 100644

--- a/Source/bindings/templates/dictionary_impl.h

+++ b/Source/bindings/templates/dictionary_impl.h

@@ -23,7 +23,7 @@ public:

{% for member in members %}

bool {{member.has_method_name}}() const { return {{member.has_method_expression}}; }

{{member.rvalue_cpp_type}} {{member.name}}() const { return {{member.getter_expression}}; }

- void {{member.setter_name}}({{member.rvalue_cpp_type}} value) { m_{{member.name}} = value;}

+ void {{member.setter_name}}({{member.rvalue_cpp_type}} value) { m_{{member.name}} = value; }

bashi 2014/08/15 16:39:39 small style correction.

{% endfor %}

void trace(Visitor*);

« no previous file with comments | « Source/bindings/scripts/v8_dictionary.py ('k') | Source/bindings/templates/dictionary_impl.cpp » ('j') | no next file with comments »