Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(358)

Unified Diff: Source/bindings/tests/results/V8TestDictionary.cpp

Issue 479563003: IDL: Set dictionary default values in impl constructor (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/bindings/tests/results/V8TestDictionary.cpp
diff --git a/Source/bindings/tests/results/V8TestDictionary.cpp b/Source/bindings/tests/results/V8TestDictionary.cpp
index d65fbd9c6fddeeaf25e28e2a5009595d78b64aad..ea135bc454bfb88e191692a59cc20449b69ce792 100644
--- a/Source/bindings/tests/results/V8TestDictionary.cpp
+++ b/Source/bindings/tests/results/V8TestDictionary.cpp
@@ -29,8 +29,6 @@ TestDictionary* V8TestDictionary::toNative(v8::Isolate* isolate, v8::Handle<v8::
int longMember;
if (DictionaryHelper::get(dictionary, "longMember", longMember))
impl->setLongMember(longMember);
- else
- impl->setLongMember(1);
Vector<String> stringArrayMember;
if (DictionaryHelper::get(dictionary, "stringArrayMember", stringArrayMember))
impl->setStringArrayMember(stringArrayMember);
@@ -40,8 +38,6 @@ TestDictionary* V8TestDictionary::toNative(v8::Isolate* isolate, v8::Handle<v8::
String stringOrNullMember;
if (DictionaryHelper::get(dictionary, "stringOrNullMember", stringOrNullMember))
impl->setStringOrNullMember(stringOrNullMember);
- else
- impl->setStringOrNullMember(String("default string value"));
Vector<String> stringSequenceMember;
if (DictionaryHelper::get(dictionary, "stringSequenceMember", stringSequenceMember))
impl->setStringSequenceMember(stringSequenceMember);

Powered by Google App Engine
This is Rietveld 408576698