Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(101)

Issue 476793002: Per P0 reqs add launch pts + make download obvious. Also misc cpy edits. (Closed)

Created:
6 years, 4 months ago by jpmedley
Modified:
6 years, 3 months ago
Reviewers:
mkearney1, smain, binji
CC:
chromium-reviews, binji+watch_chromium.org, chromium-apps-reviews_chromium.org, native-client-reviews_googlegroups.com, Sam Clegg, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Per P0 reqs add launch points + make download obvious. Also misc copy edits. BUG=none R= mkearney@chromium.org, smain@chromium.org, binji@chromium.org TEST=none NOTRY=true (documentation only change) Priority list copied here for reference: P1 But written by different engineers, very uneven quality and voice. P2 Some documentation could be expanded. P0 The ramp-in for new users could be improved. P0 The landing page isn't "cool", it doesn't make developers want to jump in and use it. Could we have a more github-like thing that gets people started quickly? Could we have a narrative intro? We just bought the pna.cl domain, we should use it! P3 We think it's pretty important to keep the deep-dive in there (e.g. sandbox internals, bitcode reference). Committed: https://crrev.com/d8030556408b675d29fd0446a10eeba50b2a2c84 Cr-Commit-Position: refs/heads/master@{#291696}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Per P0 reqs add launch pts + make download obvious. Also misc cpy edits. #

Total comments: 16

Patch Set 3 : Changes from Ben's feedback. #

Patch Set 4 : Changes to pull quote formatting. #

Patch Set 5 : CL synced with master. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+674 lines, -659 lines) Patch
M chrome/common/extensions/docs/templates/json/chrome_sidenav.json View 1 2 3 4 1 chunk +5 lines, -25 lines 0 comments Download
M native_client_sdk/doc_generated/_static/css/nacl.css View 1 2 3 1 chunk +17 lines, -0 lines 0 comments Download
M native_client_sdk/doc_generated/_static/pygments.css View 1 chunk +2 lines, -2 lines 0 comments Download
A + native_client_sdk/doc_generated/c-api.html View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M native_client_sdk/doc_generated/community/security-contest/contest-terms.html View 3 chunks +4 lines, -4 lines 0 comments Download
A + native_client_sdk/doc_generated/cpp-api.html View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M native_client_sdk/doc_generated/devguide/coding/application-structure.html View 1 2 3 4 2 chunks +3 lines, -3 lines 0 comments Download
M native_client_sdk/doc_generated/devguide/coding/audio.html View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download
M native_client_sdk/doc_generated/devguide/coding/file-io.html View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download
M native_client_sdk/doc_generated/devguide/coding/message-system.html View 1 2 3 4 1 chunk +3 lines, -3 lines 0 comments Download
M native_client_sdk/doc_generated/devguide/coding/progress-events.html View 1 2 3 4 1 chunk +2 lines, -2 lines 0 comments Download
M native_client_sdk/doc_generated/devguide/coding/url-loading.html View 1 2 3 4 2 chunks +3 lines, -3 lines 0 comments Download
M native_client_sdk/doc_generated/devguide/coding/view-focus-input-events.html View 1 2 3 4 1 chunk +3 lines, -3 lines 0 comments Download
M native_client_sdk/doc_generated/devguide/devcycle/running.html View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M native_client_sdk/doc_generated/devguide/tutorial/tutorial-part1.html View 1 2 3 4 3 chunks +12 lines, -12 lines 0 comments Download
M native_client_sdk/doc_generated/glossary.html View 1 chunk +1 line, -1 line 0 comments Download
M native_client_sdk/doc_generated/index.html View 1 2 3 4 2 chunks +45 lines, -21 lines 0 comments Download
M native_client_sdk/doc_generated/nacl-and-pnacl.html View 1 2 3 4 4 chunks +17 lines, -21 lines 0 comments Download
M native_client_sdk/doc_generated/overview.html View 1 2 3 4 3 chunks +29 lines, -36 lines 0 comments Download
A + native_client_sdk/doc_generated/pepper_stable/c-api.html View 1 2 3 4 4 chunks +9 lines, -2 lines 0 comments Download
A + native_client_sdk/doc_generated/pepper_stable/cpp-api.html View 1 2 3 4 3 chunks +4 lines, -2 lines 0 comments Download
M native_client_sdk/doc_generated/pepper_stable/index.html View 1 2 3 4 1 chunk +2 lines, -2 lines 0 comments Download
M native_client_sdk/doc_generated/sdk/download.html View 1 2 3 4 8 chunks +104 lines, -152 lines 0 comments Download
M native_client_sdk/doc_generated/sdk/examples.html View 1 2 3 4 4 chunks +40 lines, -42 lines 0 comments Download
M native_client_sdk/doc_generated/sitemap.html View 2 chunks +22 lines, -3 lines 0 comments Download
M native_client_sdk/src/doc/_static/css/nacl.css View 1 2 3 1 chunk +17 lines, -0 lines 0 comments Download
A native_client_sdk/src/doc/c-api.rst View 1 chunk +3 lines, -0 lines 0 comments Download
M native_client_sdk/src/doc/community/security-contest/contest-terms.rst View 3 chunks +4 lines, -4 lines 0 comments Download
A native_client_sdk/src/doc/cpp-api.rst View 1 chunk +3 lines, -0 lines 0 comments Download
M native_client_sdk/src/doc/devguide/coding/application-structure.rst View 2 chunks +3 lines, -3 lines 0 comments Download
M native_client_sdk/src/doc/devguide/coding/audio.rst View 2 chunks +2 lines, -2 lines 0 comments Download
M native_client_sdk/src/doc/devguide/coding/file-io.rst View 2 chunks +2 lines, -2 lines 0 comments Download
M native_client_sdk/src/doc/devguide/coding/message-system.rst View 1 chunk +3 lines, -3 lines 0 comments Download
M native_client_sdk/src/doc/devguide/coding/progress-events.rst View 1 2 3 4 1 chunk +2 lines, -2 lines 0 comments Download
M native_client_sdk/src/doc/devguide/coding/url-loading.rst View 2 chunks +3 lines, -3 lines 0 comments Download
M native_client_sdk/src/doc/devguide/coding/view-focus-input-events.rst View 1 2 3 4 1 chunk +3 lines, -3 lines 0 comments Download
M native_client_sdk/src/doc/devguide/devcycle/running.rst View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M native_client_sdk/src/doc/devguide/tutorial/tutorial-part1.rst View 3 chunks +12 lines, -12 lines 0 comments Download
M native_client_sdk/src/doc/glossary.rst View 1 chunk +1 line, -1 line 0 comments Download
M native_client_sdk/src/doc/index.rst View 1 2 3 3 chunks +63 lines, -20 lines 0 comments Download
M native_client_sdk/src/doc/nacl-and-pnacl.rst View 4 chunks +17 lines, -23 lines 0 comments Download
M native_client_sdk/src/doc/overview.rst View 1 2 4 chunks +29 lines, -36 lines 0 comments Download
M native_client_sdk/src/doc/sdk/download.rst View 1 2 7 chunks +110 lines, -155 lines 0 comments Download
M native_client_sdk/src/doc/sdk/examples.rst View 4 chunks +60 lines, -43 lines 0 comments Download
M native_client_sdk/src/doc/sitemap.rst View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 17 (0 generated)
jpmedley
More changes later.
6 years, 4 months ago (2014-08-18 15:01:08 UTC) #1
mkearney1
First quick review: -- Getting trailing whitespace errors when I take on the patch, so ...
6 years, 4 months ago (2014-08-18 21:57:34 UTC) #2
jpmedley
https://codereview.chromium.org/476793002/diff/1/native_client_sdk/doc_generated/pepper_stable/pepper-api.html File native_client_sdk/doc_generated/pepper_stable/pepper-api.html (right): https://codereview.chromium.org/476793002/diff/1/native_client_sdk/doc_generated/pepper_stable/pepper-api.html#newcode6 native_client_sdk/doc_generated/pepper_stable/pepper-api.html:6: cross-platform C/C++ API for web browser plugins. From the ...
6 years, 4 months ago (2014-08-19 00:13:18 UTC) #3
jpmedley
PTAL
6 years, 4 months ago (2014-08-19 00:57:14 UTC) #4
binji
https://codereview.chromium.org/476793002/diff/20001/native_client_sdk/doc_generated/community/index.html File native_client_sdk/doc_generated/community/index.html (right): https://codereview.chromium.org/476793002/diff/20001/native_client_sdk/doc_generated/community/index.html#newcode6 native_client_sdk/doc_generated/community/index.html:6: <strong>implementors</strong> (contributors to the <a class="reference external" href="nacl_project_">open-source Native ...
6 years, 4 months ago (2014-08-19 19:22:35 UTC) #5
jpmedley
@binji, PTAL https://codereview.chromium.org/476793002/diff/20001/native_client_sdk/doc_generated/community/index.html File native_client_sdk/doc_generated/community/index.html (right): https://codereview.chromium.org/476793002/diff/20001/native_client_sdk/doc_generated/community/index.html#newcode6 native_client_sdk/doc_generated/community/index.html:6: <strong>implementors</strong> (contributors to the <a class="reference external" ...
6 years, 4 months ago (2014-08-19 20:13:01 UTC) #6
binji
OK, lgtm https://codereview.chromium.org/476793002/diff/20001/native_client_sdk/src/doc/c-api.rst File native_client_sdk/src/doc/c-api.rst (right): https://codereview.chromium.org/476793002/diff/20001/native_client_sdk/src/doc/c-api.rst#newcode1 native_client_sdk/src/doc/c-api.rst:1: .. _c-api: On 2014/08/19 20:13:01, jmedley wrote: ...
6 years, 4 months ago (2014-08-19 20:53:16 UTC) #7
jpmedley
The CQ bit was checked by jmedley@chromium.org
6 years, 4 months ago (2014-08-25 16:01:10 UTC) #8
jpmedley
The CQ bit was unchecked by jmedley@chromium.org
6 years, 4 months ago (2014-08-25 16:01:18 UTC) #9
jpmedley
The CQ bit was checked by jmedley@chromium.org
6 years, 4 months ago (2014-08-25 16:06:09 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jmedley@chromium.org/476793002/60001
6 years, 4 months ago (2014-08-25 16:06:40 UTC) #11
jpmedley
The CQ bit was unchecked by jmedley@chromium.org
6 years, 4 months ago (2014-08-25 16:07:23 UTC) #12
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-25 16:08:12 UTC) #13
jpmedley
The CQ bit was checked by jmedley@chromium.org
6 years, 4 months ago (2014-08-25 16:40:02 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jmedley@chromium.org/476793002/80001
6 years, 4 months ago (2014-08-25 16:40:52 UTC) #15
commit-bot: I haz the power
Committed patchset #5 (80001) as bb5e3bb50ed3fe955ffdef4d7f52006546e460db
6 years, 4 months ago (2014-08-25 16:42:16 UTC) #16
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 02:35:00 UTC) #17
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/d8030556408b675d29fd0446a10eeba50b2a2c84
Cr-Commit-Position: refs/heads/master@{#291696}

Powered by Google App Engine
This is Rietveld 408576698