Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(453)

Issue 476713002: Make |extends| option in custom element behave correctly (Closed)

Created:
6 years, 4 months ago by deepak.sa
Modified:
6 years, 4 months ago
CC:
blink-reviews, blink-reviews-bindings_chromium.org, arv+blink, abarth-chromium
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Make |extends| option in custom element behave correctly When null is given to |extends| while instantiating the custom element, it should be the same case when |extends| is not specified at all. BUG=323882 TEST=fast/dom/custom/type-extension-is-null.html Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=180811

Patch Set 1 #

Patch Set 2 : Modifying equality operator #

Total comments: 2

Patch Set 3 : Updated TestExpectations #

Total comments: 6

Patch Set 4 : Updated layout tests #

Patch Set 5 : Nit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -3 lines) Patch
M LayoutTests/TestExpectations View 1 2 3 1 chunk +0 lines, -2 lines 0 comments Download
A LayoutTests/fast/dom/custom/type-extension-is-null.html View 1 2 3 1 chunk +15 lines, -0 lines 0 comments Download
A LayoutTests/fast/dom/custom/type-extension-is-null-expected.txt View 1 2 3 1 chunk +4 lines, -0 lines 0 comments Download
M Source/bindings/core/v8/CustomElementConstructorBuilder.cpp View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 24 (0 generated)
deepak.sa
PTAL? Thanks!
6 years, 4 months ago (2014-08-14 14:42:59 UTC) #1
esprehn
Why do !(...) instead of just using != ? To unsubscribe from this group and ...
6 years, 4 months ago (2014-08-14 14:45:52 UTC) #2
deepak.sa
On 2014/08/14 14:45:52, esprehn wrote: > Why do !(...) instead of just using != ? ...
6 years, 4 months ago (2014-08-14 14:49:30 UTC) #3
dominicc (has gone to gerrit)
Can we update the upstream W3C tests for Custom Elements as well? https://codereview.chromium.org/476713002/diff/20001/LayoutTests/fast/dom/custom/type-extension-is-null.html File LayoutTests/fast/dom/custom/type-extension-is-null.html ...
6 years, 4 months ago (2014-08-15 07:00:19 UTC) #4
deepak.sa
Updated TestExpectations for w3c tests for custom elements. https://codereview.chromium.org/476713002/diff/20001/LayoutTests/fast/dom/custom/type-extension-is-null.html File LayoutTests/fast/dom/custom/type-extension-is-null.html (right): https://codereview.chromium.org/476713002/diff/20001/LayoutTests/fast/dom/custom/type-extension-is-null.html#newcode9 LayoutTests/fast/dom/custom/type-extension-is-null.html:9: 'type ...
6 years, 4 months ago (2014-08-18 12:50:27 UTC) #5
dominicc (has gone to gerrit)
More comments inline. Nearly there, it just takes some care to get the tests right. ...
6 years, 4 months ago (2014-08-19 01:03:06 UTC) #6
deepak.sa
PTAL? Thanks! https://codereview.chromium.org/476713002/diff/40001/LayoutTests/fast/dom/custom/type-extension-is-null.html File LayoutTests/fast/dom/custom/type-extension-is-null.html (right): https://codereview.chromium.org/476713002/diff/40001/LayoutTests/fast/dom/custom/type-extension-is-null.html#newcode6 LayoutTests/fast/dom/custom/type-extension-is-null.html:6: var A = document.registerElement('x-foo', {extends: null, prototype: ...
6 years, 4 months ago (2014-08-19 12:34:25 UTC) #7
deepak.sa
PING!
6 years, 4 months ago (2014-08-21 06:37:57 UTC) #8
dominicc (has gone to gerrit)
The CQ bit was checked by dominicc@chromium.org
6 years, 4 months ago (2014-08-21 07:15:22 UTC) #9
dominicc (has gone to gerrit)
lgtm LGTM. Nit: It might be better without the parentheses around the != "null" test.
6 years, 4 months ago (2014-08-21 07:15:23 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/deepak.sa@samsung.com/476713002/60001
6 years, 4 months ago (2014-08-21 07:15:36 UTC) #11
deepak.sa
On 2014/08/21 07:15:23, dominicc wrote: > Nit: It might be better without the parentheses around ...
6 years, 4 months ago (2014-08-21 07:36:34 UTC) #12
dominicc (has gone to gerrit)
On 2014/08/21 07:36:34, deepak.sa wrote: > On 2014/08/21 07:15:23, dominicc wrote: > > > Nit: ...
6 years, 4 months ago (2014-08-21 08:09:54 UTC) #13
dominicc (has gone to gerrit)
+haraken for bindings. Still LGTM with nit.
6 years, 4 months ago (2014-08-21 08:10:27 UTC) #14
deepak.sa
The CQ bit was checked by deepak.sa@samsung.com
6 years, 4 months ago (2014-08-21 08:50:05 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/deepak.sa@samsung.com/476713002/80001
6 years, 4 months ago (2014-08-21 08:50:47 UTC) #16
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: blink_presubmit on tryserver.blink ...
6 years, 4 months ago (2014-08-21 19:26:43 UTC) #17
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-21 21:11:59 UTC) #18
commit-bot: I haz the power
Try jobs failed on following builders: blink_presubmit on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/blink_presubmit/builds/13442)
6 years, 4 months ago (2014-08-21 21:11:59 UTC) #19
deepak.sa
Ping! bindings/ required!
6 years, 4 months ago (2014-08-23 09:20:19 UTC) #20
haraken
bindings/ LGTM.
6 years, 4 months ago (2014-08-23 11:47:03 UTC) #21
deepak.sa
The CQ bit was checked by deepak.sa@samsung.com
6 years, 4 months ago (2014-08-23 12:16:05 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/deepak.sa@samsung.com/476713002/80001
6 years, 4 months ago (2014-08-23 12:19:20 UTC) #23
commit-bot: I haz the power
6 years, 4 months ago (2014-08-24 04:45:55 UTC) #24
Message was sent while issue was closed.
Committed patchset #5 (80001) as 180811

Powered by Google App Engine
This is Rietveld 408576698