Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(144)

Unified Diff: Source/bindings/core/v8/CustomElementConstructorBuilder.cpp

Issue 476713002: Make |extends| option in custom element behave correctly (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Nit Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « LayoutTests/fast/dom/custom/type-extension-is-null-expected.txt ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/bindings/core/v8/CustomElementConstructorBuilder.cpp
diff --git a/Source/bindings/core/v8/CustomElementConstructorBuilder.cpp b/Source/bindings/core/v8/CustomElementConstructorBuilder.cpp
index 20000fd66d7ee17ea46f1e28e3e692a0f515bdc1..9dac18b0611a8adaa0b24a6021f036e9b2e0a704 100644
--- a/Source/bindings/core/v8/CustomElementConstructorBuilder.cpp
+++ b/Source/bindings/core/v8/CustomElementConstructorBuilder.cpp
@@ -95,7 +95,7 @@ bool CustomElementConstructorBuilder::validateOptions(const AtomicString& type,
}
AtomicString extends;
- bool extendsProvidedAndNonNull = DictionaryHelper::get(*m_options, "extends", extends);
+ bool extendsProvidedAndNonNull = DictionaryHelper::get(*m_options, "extends", extends) && extends != "null";
if (tryCatch.HasCaught()) {
tryCatch.ReThrow();
« no previous file with comments | « LayoutTests/fast/dom/custom/type-extension-is-null-expected.txt ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698