Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Side by Side Diff: Source/bindings/core/v8/CustomElementConstructorBuilder.cpp

Issue 476713002: Make |extends| option in custom element behave correctly (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Nit Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « LayoutTests/fast/dom/custom/type-extension-is-null-expected.txt ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2013 Google Inc. All rights reserved. 2 * Copyright (C) 2013 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 77 matching lines...) Expand 10 before | Expand all | Expand 10 after
88 if (!basePrototype.IsEmpty()) 88 if (!basePrototype.IsEmpty())
89 m_prototype->SetPrototype(basePrototype); 89 m_prototype->SetPrototype(basePrototype);
90 } 90 }
91 91
92 if (tryCatch.HasCaught()) { 92 if (tryCatch.HasCaught()) {
93 tryCatch.ReThrow(); 93 tryCatch.ReThrow();
94 return false; 94 return false;
95 } 95 }
96 96
97 AtomicString extends; 97 AtomicString extends;
98 bool extendsProvidedAndNonNull = DictionaryHelper::get(*m_options, "extends" , extends); 98 bool extendsProvidedAndNonNull = DictionaryHelper::get(*m_options, "extends" , extends) && extends != "null";
99 99
100 if (tryCatch.HasCaught()) { 100 if (tryCatch.HasCaught()) {
101 tryCatch.ReThrow(); 101 tryCatch.ReThrow();
102 return false; 102 return false;
103 } 103 }
104 104
105 if (!m_scriptState->perContextData()) { 105 if (!m_scriptState->perContextData()) {
106 // FIXME: This should generate an InvalidContext exception at a later po int. 106 // FIXME: This should generate an InvalidContext exception at a later po int.
107 CustomElementException::throwException(CustomElementException::ContextDe stroyedCheckingPrototype, type, exceptionState); 107 CustomElementException::throwException(CustomElementException::ContextDe stroyedCheckingPrototype, type, exceptionState);
108 tryCatch.ReThrow(); 108 tryCatch.ReThrow();
(...skipping 185 matching lines...) Expand 10 before | Expand all | Expand 10 after
294 294
295 ExceptionState exceptionState(ExceptionState::ConstructionContext, "CustomEl ement", info.Holder(), info.GetIsolate()); 295 ExceptionState exceptionState(ExceptionState::ConstructionContext, "CustomEl ement", info.Holder(), info.GetIsolate());
296 CustomElementCallbackDispatcher::CallbackDeliveryScope deliveryScope; 296 CustomElementCallbackDispatcher::CallbackDeliveryScope deliveryScope;
297 RefPtrWillBeRawPtr<Element> element = document->createElementNS(namespaceURI , tagName, maybeType->IsNull() ? nullAtom : type, exceptionState); 297 RefPtrWillBeRawPtr<Element> element = document->createElementNS(namespaceURI , tagName, maybeType->IsNull() ? nullAtom : type, exceptionState);
298 if (exceptionState.throwIfNeeded()) 298 if (exceptionState.throwIfNeeded())
299 return; 299 return;
300 v8SetReturnValueFast(info, element.release(), document); 300 v8SetReturnValueFast(info, element.release(), document);
301 } 301 }
302 302
303 } // namespace blink 303 } // namespace blink
OLDNEW
« no previous file with comments | « LayoutTests/fast/dom/custom/type-extension-is-null-expected.txt ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698