LayoutTests/fast/dom/custom/type-extension-is-null.html - Issue 476713002: Make |extends| option in custom element behave correctly

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/fast/dom/custom/type-extension-is-null.html

Issue 476713002: Make |extends| option in custom element behave correctly (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Updated TestExpectations Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <script src="../../../resources/testharness.js"></script>

	3 <script src="../../../resources/testharnessreport.js"></script>

	4 <body>

	5 <script>

	6 var A = document.registerElement('x-foo', {extends: null, prototype: null});
	dominicc (has gone to gerrit) 2014/08/19 01:03:06 Move this back inside the test since it is specifi Move this back inside the test since it is specific to it. deepak.sa 2014/08/19 12:34:25 Done. Show quoted text On 2014/08/19 01:03:06, dominicc wrote: > Move this back inside the test since it is specific to it. Done.
	7

	8 test(function() {

	9 assert_equals(new A().outerHTML, '<x-foo></x-foo>',

	10 'type extension from null should be treated as if "extends" is not given ');

	11 }, 'localName should not be "null" and type extension should not have "is" attri bute');
	dominicc (has gone to gerrit) 2014/08/19 01:03:06 I think the test name and the assertion message sh I think the test name and the assertion message should be reversed. The current test name is much more specific than the assertion message. deepak.sa 2014/08/19 12:34:25 Done. Show quoted text On 2014/08/19 01:03:06, dominicc wrote: > I think the test name and the assertion message should be reversed. The current > test name is much more specific than the assertion message. Done.
	12

	13 test(function() {

	14 assert_equals(new A().localName, 'x-foo',
	dominicc (has gone to gerrit) 2014/08/19 01:03:06 I think this should be two assertions in one test I think this should be two assertions in one test and not a separate test. The nature of the test is the same. deepak.sa 2014/08/19 12:34:25 Done. Show quoted text On 2014/08/19 01:03:06, dominicc wrote: > I think this should be two assertions in one test and not a separate test. The > nature of the test is the same. Done.
	15 'localName should be set to TYPE if extends is null');

	16 }, 'If extends is null, localName is set to TYPE');

	17 </script>

OLD	NEW

« no previous file with comments | « LayoutTests/TestExpectations ('k') | LayoutTests/fast/dom/custom/type-extension-is-null-expected.txt » ('j') | no next file with comments »