Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(346)

Issue 476283006: mojo: Fix double character inserts on Windows by removing a Linux hack. (Closed)

Created:
6 years, 3 months ago by Elliot Glaysher
Modified:
6 years, 3 months ago
Reviewers:
sky
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

mojo: Fix double character inserts on Windows by removing a Linux hack. If we're going to make mojo a write-once-run-anywhere platform, we'll have to smooth over platform differences in event handling. Currently, we have code that tries to emulate this behaviour at different levels of the chrome stack on Linux. This emulation code lead to the double character insertion bug on Windows: things looked fine on Linux because we had another hack to cover up the lack of character events, which just caused double character insertion on Windows. In this patch, we declare the Windows style of events (a keydown, a translated character event, a keyup) as canonical and what should be targeted going forward. BUG=403514 Committed: https://crrev.com/ff091da898d1079cb8aca10d3016f6bc2471fc89 Cr-Commit-Position: refs/heads/master@{#292222}

Patch Set 1 #

Patch Set 2 : Apparently we're supposed to make gn work... #

Patch Set 3 : Fix windows compile by adding ifdex #

Patch Set 4 : Rewrite a comment. #

Patch Set 5 : Move input method to its own file. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+213 lines, -48 lines) Patch
M mojo/mojo.gyp View 1 2 3 4 1 chunk +2 lines, -0 lines 0 comments Download
M mojo/mojo_services.gypi View 1 1 chunk +2 lines, -0 lines 0 comments Download
M mojo/services/html_viewer/blink_input_events_type_converters.cc View 1 chunk +1 line, -7 lines 0 comments Download
M mojo/services/native_viewport/platform_viewport_x11.cc View 1 2 3 2 chunks +32 lines, -0 lines 0 comments Download
M mojo/services/public/cpp/input_events/BUILD.gn View 1 1 chunk +3 lines, -0 lines 0 comments Download
M mojo/services/public/cpp/input_events/lib/input_events_type_converters.cc View 4 chunks +11 lines, -39 lines 0 comments Download
A mojo/services/public/cpp/input_events/lib/mojo_extended_key_event_data.h View 1 chunk +39 lines, -0 lines 0 comments Download
A mojo/services/public/cpp/input_events/lib/mojo_extended_key_event_data.cc View 1 chunk +25 lines, -0 lines 0 comments Download
M mojo/services/public/interfaces/input_events/input_events.mojom View 1 chunk +5 lines, -0 lines 0 comments Download
A mojo/views/input_method_mojo_linux.h View 1 2 3 4 1 chunk +38 lines, -0 lines 0 comments Download
A mojo/views/input_method_mojo_linux.cc View 1 2 3 4 1 chunk +43 lines, -0 lines 0 comments Download
M mojo/views/native_widget_view_manager.cc View 1 2 3 4 3 chunks +9 lines, -0 lines 0 comments Download
M ui/base/ime/input_method_auralinux.h View 1 2 3 4 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Elliot Glaysher
erg@chromium.org changed reviewers: + sky@chromium.org
6 years, 3 months ago (2014-08-27 19:23:02 UTC) #1
Elliot Glaysher
6 years, 3 months ago (2014-08-27 19:23:02 UTC) #2
sky
LGTM
6 years, 3 months ago (2014-08-27 20:31:23 UTC) #3
Elliot Glaysher
The CQ bit was checked by erg@chromium.org
6 years, 3 months ago (2014-08-27 20:36:22 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/erg@chromium.org/476283006/40002
6 years, 3 months ago (2014-08-27 20:37:58 UTC) #5
commit-bot: I haz the power
Committed patchset #5 (id:40002) as 9a8466c2da88c77bba5f1a0629e39971d39cd033
6 years, 3 months ago (2014-08-27 21:15:31 UTC) #6
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 02:54:00 UTC) #7
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/ff091da898d1079cb8aca10d3016f6bc2471fc89
Cr-Commit-Position: refs/heads/master@{#292222}

Powered by Google App Engine
This is Rietveld 408576698