Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(458)

Issue 471763003: Remove deprecated methods related to tracing in browser.py. (Closed)

Created:
6 years, 4 months ago by nednguyen(REVIEW IN OTHER ACC)
Modified:
6 years, 4 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam, nednguyen, piman+watch_chromium.org, telemetry+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Remove deprecated methods related to tracing in browser.py. Switch callsites to use tracing_controller. BUG=356763 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=290671

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+122 lines, -86 lines) Patch
M content/test/gpu/gpu_tests/memory.py View 3 chunks +9 lines, -2 lines 0 comments Download
M tools/perf/measurements/image_decoding.py View 4 chunks +21 lines, -6 lines 0 comments Download
M tools/perf/measurements/smoothness_controller.py View 4 chunks +11 lines, -4 lines 0 comments Download
M tools/perf/measurements/smoothness_unittest.py View 3 chunks +14 lines, -8 lines 0 comments Download
M tools/perf/measurements/timeline_controller.py View 4 chunks +9 lines, -5 lines 0 comments Download
M tools/telemetry/telemetry/core/backends/chrome/tracing_backend_unittest.py View 2 chunks +11 lines, -6 lines 0 comments Download
M tools/telemetry/telemetry/core/browser.py View 3 chunks +0 lines, -29 lines 0 comments Download
M tools/telemetry/telemetry/core/browser_unittest.py View 2 chunks +12 lines, -6 lines 0 comments Download
M tools/telemetry/telemetry/core/tab_unittest.py View 4 chunks +13 lines, -7 lines 0 comments Download
M tools/telemetry/telemetry/page/actions/action_runner_unittest.py View 2 chunks +7 lines, -2 lines 0 comments Download
M tools/telemetry/telemetry/unittest/page_test_test_case.py View 1 chunk +6 lines, -5 lines 0 comments Download
M tools/telemetry/telemetry/web_perf/timeline_based_measurement.py View 4 chunks +9 lines, -6 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
nduca
lgtm
6 years, 4 months ago (2014-08-19 17:55:02 UTC) #1
nednguyen
The CQ bit was checked by nednguyen@google.com
6 years, 4 months ago (2014-08-19 17:55:14 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nednguyen@chromium.org/471763003/20001
6 years, 4 months ago (2014-08-19 17:55:49 UTC) #3
nednguyen
6 years, 4 months ago (2014-08-19 18:05:02 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: chromium_presubmit on tryserver.chromium.linux ...
6 years, 4 months ago (2014-08-19 19:21:52 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-19 19:25:47 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/5289)
6 years, 4 months ago (2014-08-19 19:25:48 UTC) #7
Ken Russell (switch to Gerrit)
content/test/gpu LGTM
6 years, 4 months ago (2014-08-19 19:44:16 UTC) #8
nednguyen
The CQ bit was checked by nednguyen@google.com
6 years, 4 months ago (2014-08-19 20:52:39 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nednguyen@chromium.org/471763003/20001
6 years, 4 months ago (2014-08-19 20:53:32 UTC) #10
commit-bot: I haz the power
6 years, 4 months ago (2014-08-19 21:56:17 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (20001) as 290671

Powered by Google App Engine
This is Rietveld 408576698