Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(797)

Unified Diff: tools/telemetry/telemetry/page/actions/action_runner_unittest.py

Issue 471763003: Remove deprecated methods related to tracing in browser.py. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/telemetry/telemetry/page/actions/action_runner_unittest.py
diff --git a/tools/telemetry/telemetry/page/actions/action_runner_unittest.py b/tools/telemetry/telemetry/page/actions/action_runner_unittest.py
index 2aa50d77108b4133fdc05ef404a505572720eef2..78371db3cafb46175a37baf807217ba586af4ad5 100644
--- a/tools/telemetry/telemetry/page/actions/action_runner_unittest.py
+++ b/tools/telemetry/telemetry/page/actions/action_runner_unittest.py
@@ -5,6 +5,8 @@
from telemetry import benchmark
from telemetry.core import exceptions
from telemetry.core import util
+from telemetry.core.platform import tracing_category_filter
+from telemetry.core.platform import tracing_options
from telemetry.page.actions import action_runner as action_runner_module
from telemetry.page.actions import page_action
from telemetry.timeline import model
@@ -28,11 +30,14 @@ class ActionRunnerInteractionTest(tab_test_case.TabTestCase):
skip_waits=True)
self.Navigate('interaction_enabled_page.html')
action_runner.Wait(1)
- self._browser.StartTracing()
+ options = tracing_options.TracingOptions()
+ options.enable_chrome_trace = True
+ self._browser.platform.tracing_controller.Start(
+ options, tracing_category_filter.CreateNoOverheadFilter())
interaction = action_runner.BeginInteraction('InteractionName',
**interaction_kwargs)
interaction.End()
- trace_data = self._browser.StopTracing()
+ trace_data = self._browser.platform.tracing_controller.Stop()
records = self.GetInteractionRecords(trace_data)
self.assertEqual(
« no previous file with comments | « tools/telemetry/telemetry/core/tab_unittest.py ('k') | tools/telemetry/telemetry/unittest/page_test_test_case.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698