Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(418)

Unified Diff: tools/telemetry/telemetry/web_perf/timeline_based_measurement.py

Issue 471763003: Remove deprecated methods related to tracing in browser.py. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/telemetry/telemetry/unittest/page_test_test_case.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/telemetry/telemetry/web_perf/timeline_based_measurement.py
diff --git a/tools/telemetry/telemetry/web_perf/timeline_based_measurement.py b/tools/telemetry/telemetry/web_perf/timeline_based_measurement.py
index 709c8a3dd4ced014a45a73f54b63718ad9d26b74..c399fcacd41564e25e0f621b91dc0a05f2f56b13 100644
--- a/tools/telemetry/telemetry/web_perf/timeline_based_measurement.py
+++ b/tools/telemetry/telemetry/web_perf/timeline_based_measurement.py
@@ -8,6 +8,7 @@ from collections import defaultdict
from telemetry.core import util
from telemetry.core.platform import tracing_category_filter
+from telemetry.core.platform import tracing_options
from telemetry.page import page_test
from telemetry.timeline import model as model_module
from telemetry.value import string as string_value_module
@@ -152,7 +153,8 @@ class TimelineBasedMeasurement(page_test.PageTest):
'is not set, the trace will not be saved.'))
def WillNavigateToPage(self, page, tab):
- if not tab.browser.supports_tracing:
+ if not tab.browser.platform.tracing_controller.IsChromeTracingSupported(
+ tab.browser):
raise Exception('Not supported')
assert self.options.overhead_level in ALL_OVERHEAD_LEVELS
@@ -170,12 +172,13 @@ class TimelineBasedMeasurement(page_test.PageTest):
for delay in page.GetSyntheticDelayCategories():
category_filter.AddSyntheticDelay(delay)
-
- tab.browser.StartTracing(category_filter)
+ options = tracing_options.TracingOptions()
+ options.enable_chrome_trace = True
+ tab.browser.platform.tracing_controller.Start(options, category_filter)
def ValidateAndMeasurePage(self, page, tab, results):
""" Collect all possible metrics and added them to results. """
- trace_result = tab.browser.StopTracing()
+ trace_result = tab.browser.platform.tracing_controller.Stop()
trace_dir = self.options.trace_dir
if trace_dir:
trace_file_path = util.GetSequentialFileName(
@@ -195,5 +198,5 @@ class TimelineBasedMeasurement(page_test.PageTest):
meta_metrics.AddResults(results)
def CleanUpAfterPage(self, page, tab):
- if tab.browser.is_tracing_running:
- tab.browser.StopTracing()
+ if tab.browser.platform.tracing_controller.is_tracing_running:
+ tab.browser.platform.tracing_controller.Stop()
« no previous file with comments | « tools/telemetry/telemetry/unittest/page_test_test_case.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698