Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(176)

Unified Diff: tools/telemetry/telemetry/core/browser.py

Issue 471763003: Remove deprecated methods related to tracing in browser.py. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/telemetry/telemetry/core/browser.py
diff --git a/tools/telemetry/telemetry/core/browser.py b/tools/telemetry/telemetry/core/browser.py
index c711b0939a89b82a44e035c5c433e249a3838fd6..d4adc9ee24a3310e289f598e0e48daed8a8ca0c1 100644
--- a/tools/telemetry/telemetry/core/browser.py
+++ b/tools/telemetry/telemetry/core/browser.py
@@ -14,8 +14,6 @@ from telemetry.core import tab_list
from telemetry.core import wpr_modes
from telemetry.core import wpr_server
from telemetry.core.backends import browser_backend
-from telemetry.core.platform import tracing_category_filter
-from telemetry.core.platform import tracing_options
from telemetry.core.platform.profiler import profiler_finder
@@ -95,10 +93,6 @@ class Browser(object):
'Extensions not supported')
return extension_dict.ExtensionDict(self._browser_backend.extension_backend)
- @property
- def supports_tracing(self):
- return self.platform.tracing_controller.IsChromeTracingSupported(self)
-
def is_profiler_active(self, profiler_name):
return profiler_name in [profiler.name() for
profiler in self._active_profilers]
@@ -274,29 +268,6 @@ class Browser(object):
self._active_profilers = []
return output_files
-
- def StartTracing(self, custom_categories=None, timeout=10):
- """Note: this function is deprecated. Prefer platform.tracing_controller."""
- if not isinstance(custom_categories,
- tracing_category_filter.TracingCategoryFilter):
- category_filter = tracing_category_filter.TracingCategoryFilter(
- filter_string=custom_categories)
- else:
- category_filter = custom_categories
- options = tracing_options.TracingOptions()
- options.enable_chrome_trace = True
- return self.platform.tracing_controller.Start(
- options, category_filter, timeout)
-
- @property
- def is_tracing_running(self):
- """Note: this function is deprecated. Prefer platform.tracing_controller."""
- return self.platform.tracing_controller.is_tracing_running
-
- def StopTracing(self):
- """Note: this function is deprecated. Prefer platform.tracing_controller."""
- return self.platform.tracing_controller.Stop()
-
def Start(self):
browser_options = self._browser_backend.browser_options
self.platform.FlushDnsCache()

Powered by Google App Engine
This is Rietveld 408576698