Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(169)

Issue 470633003: Revert of Port suitableForGpuRasterization to SkRecord (Closed)

Created:
6 years, 4 months ago by mtklein
Modified:
6 years, 4 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Revert of Port suitableForGpuRasterization to SkRecord (patchset #12 of https://codereview.chromium.org/364823009/) Reason for revert: test_gpu_veto(reporter, true) failing on many bots Original issue's description: > Move the code over using the same template type approach previously used for willPlayBackBitmaps in http://skbug.com/2702. > > Also unifies that flag and this one into a struct so they and others can be computed together. The struct is stored const to enforce lifetime expectations. Adds a few new cases to the unit test. > > BUG=skia:2700 > R=mtklein@google.com,reed@google.com,robertphillips@google.com > > Committed: https://skia.googlesource.com/skia/+/60c2a79cfa8ceebcbafc243407564dc71f5e3b4f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+127 lines, -272 lines) Patch
M gyp/core.gypi View 1 chunk +2 lines, -0 lines 0 comments Download
M include/core/SkPicture.h View 1 chunk +1 line, -10 lines 0 comments Download
M src/core/SkPicture.cpp View 8 chunks +11 lines, -181 lines 0 comments Download
A src/core/SkRecordAnalysis.h View 1 chunk +8 lines, -0 lines 0 comments Download
A src/core/SkRecordAnalysis.cpp View 1 chunk +66 lines, -0 lines 0 comments Download
M tests/PictureTest.cpp View 6 chunks +6 lines, -81 lines 0 comments Download
M tests/RecordTest.cpp View 2 chunks +33 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
mtklein
Created Revert of Port suitableForGpuRasterization to SkRecord
6 years, 4 months ago (2014-08-18 22:30:40 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/mtklein@google.com/470633003/1
6 years, 4 months ago (2014-08-18 22:30:52 UTC) #2
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
6 years, 4 months ago (2014-08-18 22:30:53 UTC) #3
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: Build-Mac10.8-Clang-x86_64-Release-Trybot on tryserver.skia ...
6 years, 4 months ago (2014-08-18 22:32:52 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-18 22:33:52 UTC) #5
commit-bot: I haz the power
6 years, 4 months ago (2014-08-18 22:33:53 UTC) #6
Try jobs failed on following builders:
  Build-Ubuntu13.10-Clang-x86_64-Debug-Trybot on tryserver.skia
(http://108.170.220.76:10117/builders/Build-Ubuntu13.10-Clang-x86_64-Debug-Try...)
  Build-Ubuntu13.10-GCC4.8-Arm7-Debug-Android-Trybot on tryserver.skia
(http://108.170.220.76:10117/builders/Build-Ubuntu13.10-GCC4.8-Arm7-Debug-Andr...)
  Build-Ubuntu13.10-GCC4.8-x86_64-Release-Trybot on tryserver.skia
(http://108.170.220.76:10117/builders/Build-Ubuntu13.10-GCC4.8-x86_64-Release-...)
  Test-Ubuntu13.10-GCE-NoGPU-x86_64-Debug-Trybot on tryserver.skia
(http://108.170.220.120:10117/builders/Test-Ubuntu13.10-GCE-NoGPU-x86_64-Debug...)
  Test-Ubuntu13.10-GCE-NoGPU-x86_64-Release-Shared-Trybot on tryserver.skia
(http://108.170.220.120:10117/builders/Test-Ubuntu13.10-GCE-NoGPU-x86_64-Relea...)

Powered by Google App Engine
This is Rietveld 408576698