Issue 468643002: Revert 288464 "[Sync] Cleanup datatype configuration error handl..."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 468643002: Revert 288464 "[Sync] Cleanup datatype configuration error handl..." (Closed)

Created:
6 years, 4 months ago by oshima

Modified:
6 years, 4 months ago

Reviewers:
Nicolas Zea

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/

Visibility:
Public.

More Reviews

Description

Revert 288464 "[Sync] Cleanup datatype configuration error handl..." Reason for revert: see crbug.com/403098 > [Sync] Cleanup datatype configuration error handling. > > The FailedDataTypeHandler is now informed immediately of failures, including > datatype errors, and is therefore authoritative source for all errors. As such, > partial success is no longer tracked and the various ModelTypeSets for error > types in configure results are removed. > > BUG=368834, 403098 > > Review URL: https://codereview.chromium.org/420633002 TBR=zea@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=289115

Patch Set 1 #

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+495 lines, -400 lines)			Patch
M	trunk/src/chrome/browser/sync/backend_migrator.cc	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	trunk/src/chrome/browser/sync/backend_migrator_unittest.cc	View	1 chunk	+5 lines, -1 line	0 comments	Download
M	trunk/src/chrome/browser/sync/glue/autofill_data_type_controller_unittest.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	trunk/src/chrome/browser/sync/glue/frontend_data_type_controller.h	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	trunk/src/chrome/browser/sync/glue/frontend_data_type_controller.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	trunk/src/chrome/browser/sync/glue/frontend_data_type_controller_mock.h	View	2 chunks	+3 lines, -3 lines	0 comments	Download
M	trunk/src/chrome/browser/sync/glue/frontend_data_type_controller_unittest.cc	View	3 chunks	+3 lines, -3 lines	0 comments	Download
M	trunk/src/chrome/browser/sync/glue/non_frontend_data_type_controller.h	View	2 chunks	+3 lines, -3 lines	0 comments	Download
M	trunk/src/chrome/browser/sync/glue/non_frontend_data_type_controller.cc	View	3 chunks	+3 lines, -3 lines	0 comments	Download
M	trunk/src/chrome/browser/sync/glue/non_frontend_data_type_controller_mock.h	View	2 chunks	+3 lines, -3 lines	0 comments	Download
M	trunk/src/chrome/browser/sync/glue/non_frontend_data_type_controller_unittest.cc	View	3 chunks	+3 lines, -3 lines	0 comments	Download
M	trunk/src/chrome/browser/sync/profile_sync_service.cc	View	4 chunks	+12 lines, -9 lines	0 comments	Download
M	trunk/src/chrome/browser/sync/profile_sync_service_startup_unittest.cc	View	7 chunks	+17 lines, -26 lines	0 comments	Download
M	trunk/src/components/sync_driver/data_type_controller.h	View	3 chunks	+4 lines, -5 lines	0 comments	Download
M	trunk/src/components/sync_driver/data_type_controller.cc	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	trunk/src/components/sync_driver/data_type_controller_mock.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	trunk/src/components/sync_driver/data_type_manager.h	View	2 chunks	+21 lines, -2 lines	0 comments	Download
M	trunk/src/components/sync_driver/data_type_manager.cc	View	2 chunks	+20 lines, -4 lines	0 comments	Download
M	trunk/src/components/sync_driver/data_type_manager_impl.h	View	2 chunks	+3 lines, -4 lines	0 comments	Download
M	trunk/src/components/sync_driver/data_type_manager_impl.cc	View	8 chunks	+72 lines, -40 lines	0 comments	Download
M	trunk/src/components/sync_driver/data_type_manager_impl_unittest.cc	View	6 chunks	+5 lines, -39 lines	0 comments	Download
M	trunk/src/components/sync_driver/failed_data_types_handler.h	View	1 chunk	+2 lines, -8 lines	0 comments	Download
M	trunk/src/components/sync_driver/failed_data_types_handler.cc	View	4 chunks	+3 lines, -21 lines	0 comments	Download
M	trunk/src/components/sync_driver/fake_data_type_controller.h	View	2 chunks	+13 lines, -8 lines	0 comments	Download
M	trunk/src/components/sync_driver/fake_data_type_controller.cc	View	7 chunks	+9 lines, -27 lines	0 comments	Download
M	trunk/src/components/sync_driver/model_association_manager.h	View	4 chunks	+19 lines, -4 lines	0 comments	Download
M	trunk/src/components/sync_driver/model_association_manager.cc	View	12 chunks	+109 lines, -62 lines	0 comments	Download
M	trunk/src/components/sync_driver/model_association_manager_unittest.cc	View	11 chunks	+100 lines, -53 lines	0 comments	Download
M	trunk/src/components/sync_driver/non_ui_data_type_controller.h	View	2 chunks	+3 lines, -3 lines	0 comments	Download
M	trunk/src/components/sync_driver/non_ui_data_type_controller.cc	View	9 chunks	+19 lines, -22 lines	0 comments	Download
M	trunk/src/components/sync_driver/non_ui_data_type_controller_mock.h	View	1 chunk	+3 lines, -3 lines	0 comments	Download
M	trunk/src/components/sync_driver/non_ui_data_type_controller_unittest.cc	View	5 chunks	+9 lines, -7 lines	0 comments	Download
M	trunk/src/components/sync_driver/ui_data_type_controller.h	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	trunk/src/components/sync_driver/ui_data_type_controller.cc	View	6 chunks	+11 lines, -17 lines	0 comments	Download
M	trunk/src/components/sync_driver/ui_data_type_controller_unittest.cc	View	2 chunks	+4 lines, -4 lines	0 comments	Download
M	trunk/src/sync/api/sync_error.cc	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Message was sent while issue was closed.

Committed patchset #1 manually as r289115.

Expand Messages | Collapse Messages