Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(248)

Unified Diff: trunk/src/components/sync_driver/data_type_manager.h

Issue 468643002: Revert 288464 "[Sync] Cleanup datatype configuration error handl..." (Closed) Base URL: svn://svn.chromium.org/chrome/
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: trunk/src/components/sync_driver/data_type_manager.h
===================================================================
--- trunk/src/components/sync_driver/data_type_manager.h (revision 289114)
+++ trunk/src/components/sync_driver/data_type_manager.h (working copy)
@@ -37,7 +37,8 @@
// this.
enum ConfigureStatus {
UNKNOWN = -1,
- OK, // Configuration finished some or all types.
+ OK, // Configuration finished without error.
+ PARTIAL_SUCCESS, // Some data types had an error while starting up.
ABORTED, // Start was aborted by calling Stop() before
// all types were started.
UNRECOVERABLE_ERROR // We got an unrecoverable error during startup.
@@ -48,10 +49,28 @@
ConfigureResult();
ConfigureResult(ConfigureStatus status,
syncer::ModelTypeSet requested_types);
+ ConfigureResult(ConfigureStatus status,
+ syncer::ModelTypeSet requested_types,
+ std::map<syncer::ModelType, syncer::SyncError>
+ failed_data_types,
+ syncer::ModelTypeSet unfinished_data_types,
+ syncer::ModelTypeSet needs_crypto);
~ConfigureResult();
-
ConfigureStatus status;
syncer::ModelTypeSet requested_types;
+
+ // These types encountered a failure in association.
+ std::map<syncer::ModelType, syncer::SyncError> failed_data_types;
+
+ // List of types that failed to finish loading/associating within our
+ // alloted time period(see |kAssociationTimeOutInSeconds|). We move
+ // forward here and allow these types to continue to load/associate in
+ // the background.
+ syncer::ModelTypeSet unfinished_data_types;
+
+ // Those types that are unable to start due to the cryptographer not being
+ // ready.
+ syncer::ModelTypeSet needs_crypto;
};
virtual ~DataTypeManager() {}
« no previous file with comments | « trunk/src/components/sync_driver/data_type_controller_mock.h ('k') | trunk/src/components/sync_driver/data_type_manager.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698