trunk/src/components/sync_driver/ui_data_type_controller_unittest.cc - Issue 468643002: Revert 288464 "[Sync] Cleanup datatype configuration error handl..."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: trunk/src/components/sync_driver/ui_data_type_controller_unittest.cc

Issue 468643002: Revert 288464 "[Sync] Cleanup datatype configuration error handl..." (Closed) Base URL: svn://svn.chromium.org/chrome/

Patch Set: Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: trunk/src/components/sync_driver/ui_data_type_controller_unittest.cc

===================================================================

--- trunk/src/components/sync_driver/ui_data_type_controller_unittest.cc (revision 289114)

+++ trunk/src/components/sync_driver/ui_data_type_controller_unittest.cc (working copy)

@@ -15,7 +15,6 @@

#include "testing/gtest/include/gtest/gtest.h"

using testing::_;

-using testing::Invoke;

using testing::InvokeWithoutArgs;

using testing::Return;

@@ -197,10 +196,11 @@

EXPECT_FALSE(syncable_service_.syncing());

Start();

EXPECT_TRUE(syncable_service_.syncing());

- testing::Mock::VerifyAndClearExpectations(&start_callback_);

- EXPECT_CALL(start_callback_, Run(DataTypeController::RUNTIME_ERROR, _, _));

preference_dtc_->OnSingleDatatypeUnrecoverableError(FROM_HERE, "Test");

+ PumpLoop();

+ EXPECT_EQ(DataTypeController::NOT_RUNNING, preference_dtc_->state());

+ EXPECT_TRUE(disable_callback_invoked_);

+ EXPECT_FALSE(syncable_service_.syncing());

}

} // namespace