Revert 288464 "[Sync] Cleanup datatype configuration error handl..."

trunk/src/components/sync_driver/non_ui_data_type_controller_unittest.cc

Index: trunk/src/components/sync_driver/non_ui_data_type_controller_unittest.cc
===================================================================
--- trunk/src/components/sync_driver/non_ui_data_type_controller_unittest.cc	(revision 289114)
+++ trunk/src/components/sync_driver/non_ui_data_type_controller_unittest.cc	(working copy)
@@ -159,7 +159,7 @@
   virtual void RecordAssociationTime(base::TimeDelta time) OVERRIDE {
     mock_->RecordAssociationTime(time);
   }
-  virtual void RecordStartFailure(DataTypeController::ConfigureResult result)
+  virtual void RecordStartFailure(DataTypeController::StartResult result)
       OVERRIDE {
     mock_->RecordStartFailure(result);
   }
@@ -243,7 +243,7 @@
     EXPECT_CALL(*dtc_mock_.get(), RecordAssociationTime(_));
   }
 
-  void SetActivateExpectations(DataTypeController::ConfigureResult result) {
+  void SetActivateExpectations(DataTypeController::StartResult result) {
     EXPECT_CALL(start_callback_, Run(result,_,_));
   }
 
@@ -252,7 +252,7 @@
     EXPECT_CALL(*change_processor_.get(), Disconnect()).WillOnce(Return(true));
   }
 
-  void SetStartFailExpectations(DataTypeController::ConfigureResult result) {
+  void SetStartFailExpectations(DataTypeController::StartResult result) {
     EXPECT_CALL(*dtc_mock_.get(), StopModels()).Times(AtLeast(1));
     EXPECT_CALL(*dtc_mock_.get(), RecordStartFailure(result));
     EXPECT_CALL(start_callback_, Run(result, _, _));
@@ -496,17 +496,17 @@
   EXPECT_EQ(DataTypeController::RUNNING, non_ui_dtc_->state());
 }
 
-TEST_F(SyncNonUIDataTypeControllerTest, OnSingleDatatypeUnrecoverableError) {
+TEST_F(SyncNonUIDataTypeControllerTest,
+       OnSingleDatatypeUnrecoverableError) {
   SetStartExpectations();
   SetAssociateExpectations();
   SetActivateExpectations(DataTypeController::OK);
+  SetStopExpectations();
   EXPECT_EQ(DataTypeController::NOT_RUNNING, non_ui_dtc_->state());
   Start();
   WaitForDTC();
   EXPECT_EQ(DataTypeController::RUNNING, non_ui_dtc_->state());
-
-  testing::Mock::VerifyAndClearExpectations(&start_callback_);
-  EXPECT_CALL(start_callback_, Run(DataTypeController::RUNTIME_ERROR, _, _));
+  // This should cause non_ui_dtc_->Stop() to be called.
   backend_thread_.message_loop_proxy()->PostTask(FROM_HERE, base::Bind(
       &NonUIDataTypeControllerFake::
           OnSingleDatatypeUnrecoverableError,
@@ -514,6 +514,8 @@
       FROM_HERE,
       std::string("Test")));
   WaitForDTC();
+  EXPECT_EQ(DataTypeController::NOT_RUNNING, non_ui_dtc_->state());
+  EXPECT_TRUE(disable_callback_invoked_);
 }
 
 }  // namespace