Issue 467003003: Revert 291214 "Fixes three crashes" in an attempt to find the cause of Athena related unit test fai…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 467003003: Revert 291214 "Fixes three crashes" in an attempt to find the cause of Athena related unit test fai… (Closed)

Created:
6 years, 4 months ago by Finnur

Modified:
6 years, 4 months ago

Reviewers:
oshima

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/

Visibility:
Public.

Revert 291214 "Fixes three crashes" in an attempt to find the cause of Athena related unit test failures on the ASAN bot. http://build.chromium.org/p/chromium.memory/buildstatus?builder=Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%283%29&number=2862 > Fixes three crashes > * AppListViewDelegate was accessing deleted search_provider. > * DeviceSocketListener::StopListening can happen after DeviceSocketManager is deleted > * Explicitly delete FilePathWatcher. This was causing > recursive callback to FilePathWatcherImpl::Cancel from > FilePathWatcherImpl::CancelOnMessageLoopThread, which > caused crash. > > > Clean ups > * change OnIO to OnFILE as they run on FILE thread. > * removed unused singleton related code. > > BUG=None > TEST=Run athena_main on desktop and close window. > > Review URL: https://codereview.chromium.org/490033003 TBR=oshima@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=291394

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+58 lines, -116 lines)			Patch
M	trunk/src/athena/home/home_card_impl.cc	View	1 chunk	+0 lines, -5 lines	0 comments	Download
M	trunk/src/athena/system/device_socket_listener.h	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	trunk/src/athena/system/device_socket_listener.cc	View	10 chunks	+33 lines, -56 lines	0 comments	Download
M	trunk/src/athena/system/orientation_controller.h	View	2 chunks	+5 lines, -16 lines	0 comments	Download
M	trunk/src/athena/system/orientation_controller.cc	View	3 chunks	+12 lines, -29 lines	0 comments	Download
M	trunk/src/athena/system/system_ui_impl.cc	View	2 chunks	+6 lines, -8 lines	0 comments	Download

Total messages: 4 (0 generated)

Message was sent while issue was closed.

thanks for taking care of it.