Fixes three crashes

Fixes three crashes
 * AppListViewDelegate was accessing deleted search_provider.
 * DeviceSocketListener::StopListening can happen after DeviceSocketManager is deleted
 * Explicitly delete FilePathWatcher. This was causing
   recursive callback to FilePathWatcherImpl::Cancel from
   FilePathWatcherImpl::CancelOnMessageLoopThread, which
   caused crash.


Clean ups
 * change OnIO to OnFILE as they run on FILE thread.
 * removed unused singleton related code.

BUG=None
TEST=Run athena_main on desktop and close window.

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=291214

R=flackr@chromium.org, mukai@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=291423

[oshima, 2014-08-21 01:32:42]

mukai -> athena/home
flackr -> the rest

https://codereview.chromium.org/490033003/diff/40001/athena/system/device_soc...
File athena/system/device_socket_listener.cc (right):

https://codereview.chromium.org/490033003/diff/40001/athena/system/device_soc...
athena/system/device_socket_listener.cc:173: base::Unretained(this),
let me know if you prefer to make this RefcountedThreadSafe

https://codereview.chromium.org/490033003/diff/40001/athena/system/device_soc...
athena/system/device_socket_listener.cc:307:
instance->StopListening(socket_path_, this);
This is called from dtor, which can happen after the manager is deleted.

[flackr, 2014-08-21 03:24:55]

https://codereview.chromium.org/490033003/diff/60001/athena/system/orientatio...
File athena/system/orientation_controller.cc (right):

https://codereview.chromium.org/490033003/diff/60001/athena/system/orientatio...
athena/system/orientation_controller.cc:76: void
OrientationController::StopWatchingSocketPath() {
This doesn't just stop watching for the socket path, it also stops listening on
the socket (if listening). Can we call it Shutdown or something to this effect?

https://codereview.chromium.org/490033003/diff/60001/athena/system/orientatio...
athena/system/orientation_controller.cc:78: watcher_.reset();
I don't think this is safe, since this is now called before the object
destruction (on the UI thread) we could be in the middle of
WatchForSocketPathOnFILE which creates the watcher. We should schedule it to be
deleted on the FILE thread.

[Jun Mukai, 2014-08-21 04:18:41]

athena/home lgtm

[oshima, 2014-08-21 15:03:41]

https://codereview.chromium.org/490033003/diff/60001/athena/system/orientatio...
File athena/system/orientation_controller.cc (right):

https://codereview.chromium.org/490033003/diff/60001/athena/system/orientatio...
athena/system/orientation_controller.cc:76: void
OrientationController::StopWatchingSocketPath() {
On 2014/08/21 03:24:55, flackr wrote:
> This doesn't just stop watching for the socket path, it also stops listening
on
> the socket (if listening). Can we call it Shutdown or something to this
effect?

Done.

https://codereview.chromium.org/490033003/diff/60001/athena/system/orientatio...
athena/system/orientation_controller.cc:78: watcher_.reset();
On 2014/08/21 03:24:55, flackr wrote:
> I don't think this is safe, since this is now called before the object
> destruction (on the UI thread) we could be in the middle of
> WatchForSocketPathOnFILE which creates the watcher. We should schedule it to
be
> deleted on the FILE thread.

Thank you for the catch. Fixed. I also added shutdown_ flag to skip
OnFilePathChangedOnFILE after shutdown.

[flackr, 2014-08-21 15:07:22]

lgtm

https://codereview.chromium.org/490033003/diff/120001/athena/system/orientati...
File athena/system/orientation_controller.cc (right):

https://codereview.chromium.org/490033003/diff/120001/athena/system/orientati...
athena/system/orientation_controller.cc:108: if (error || shutdown_)
Not sure this check of shutdown_ is necessary. Since ShutdownOnFILE which sets
shutdown_ runs on the same thread and destructs the watcher I don't think this
can be called if it is shutdown_.

[oshima, 2014-08-21 16:41:00]

https://codereview.chromium.org/490033003/diff/120001/athena/system/orientati...
File athena/system/orientation_controller.cc (right):

https://codereview.chromium.org/490033003/diff/120001/athena/system/orientati...
athena/system/orientation_controller.cc:108: if (error || shutdown_)
On 2014/08/21 15:07:22, flackr wrote:
> Not sure this check of shutdown_ is necessary. Since ShutdownOnFILE which sets
> shutdown_ runs on the same thread and destructs the watcher I don't think this
> can be called if it is shutdown_.

FilePathWatcherImpl, which really watches the file, seems to outlive
FilePathWatcher. This won't really happen in real scenario, but this is to make
sure it wont cause an problem in test or desktop.

[oshima, 2014-08-21 16:41:41]

The CQ bit was checked by oshima@chromium.org

[commit-bot: I haz the power, 2014-08-21 16:43:01]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/oshima@chromium.org/490033003/120001

[commit-bot: I haz the power, 2014-08-21 19:44:35]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  linux_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu/builds/...)

[commit-bot: I haz the power, 2014-08-21 22:12:07]

Committed patchset #5 (120001) as 291214

[oshima, 2014-08-22 14:57:35]

rob, there is a leak because there was no FILE thread on unit tests :)

I create one, but no other change to original CL. I'll go ahead and land this
once try job passed, but let me know if you have any concern or question.

[oshima, 2014-08-22 16:13:31]

Committed patchset #6 manually as 291423 (presubmit successful).