Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Unified Diff: trunk/src/athena/system/orientation_controller.h

Issue 467003003: Revert 291214 "Fixes three crashes" in an attempt to find the cause of Athena related unit test fai… (Closed) Base URL: svn://svn.chromium.org/chrome/
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: trunk/src/athena/system/orientation_controller.h
===================================================================
--- trunk/src/athena/system/orientation_controller.h (revision 291393)
+++ trunk/src/athena/system/orientation_controller.h (working copy)
@@ -28,22 +28,19 @@
public:
OrientationController();
- void InitWith(scoped_refptr<base::TaskRunner> file_task_runner);
+ void InitWith(scoped_refptr<base::TaskRunner> io_task_runner);
- void Shutdown();
-
private:
friend class base::RefCountedThreadSafe<OrientationController>;
virtual ~OrientationController();
- void ShutdownOnFILE();
- // Watch for the socket path to be created, called on the FILE thread.
- void WatchForSocketPathOnFILE();
- void OnFilePathChangedOnFILE(const base::FilePath& path, bool error);
+ // Watch for the socket path to be created, called on the IO thread.
+ void WatchForSocketPathOnIO();
+ void OnFilePathChangedOnIO(const base::FilePath& path, bool error);
// Overridden from device::DeviceSocketListener:
- virtual void OnDataAvailableOnFILE(const void* data) OVERRIDE;
+ virtual void OnDataAvailableOnIO(const void* data) OVERRIDE;
// Rotates the display to |rotation|, called on the UI thread.
void RotateOnUI(gfx::Display::Rotation rotation);
@@ -54,17 +51,9 @@
// The timestamp of the last applied orientation change.
int64_t last_orientation_change_time_;
- // True if the OrientaionController has already been shutdown.
- // This is initialized on UI thread, but must be accessed / modified
- // only on FILE thread.
- bool shutdown_;
-
// A task runner for the UI thread.
scoped_refptr<base::TaskRunner> ui_task_runner_;
- // A task runner for the FILE thread.
- scoped_refptr<base::TaskRunner> file_task_runner_;
-
// File path watcher used to detect when sensors are present.
scoped_ptr<base::FilePathWatcher> watcher_;
« no previous file with comments | « trunk/src/athena/system/device_socket_listener.cc ('k') | trunk/src/athena/system/orientation_controller.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698