Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(58)

Unified Diff: trunk/src/athena/system/system_ui_impl.cc

Issue 467003003: Revert 291214 "Fixes three crashes" in an attempt to find the cause of Athena related unit test fai… (Closed) Base URL: svn://svn.chromium.org/chrome/
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « trunk/src/athena/system/orientation_controller.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: trunk/src/athena/system/system_ui_impl.cc
===================================================================
--- trunk/src/athena/system/system_ui_impl.cc (revision 291393)
+++ trunk/src/athena/system/system_ui_impl.cc (working copy)
@@ -18,16 +18,13 @@
class SystemUIImpl : public SystemUI {
public:
- SystemUIImpl(scoped_refptr<base::TaskRunner> file_task_runner)
+ SystemUIImpl(scoped_refptr<base::TaskRunner> io_task_runner)
: orientation_controller_(new OrientationController()),
power_button_controller_(new PowerButtonController) {
- orientation_controller_->InitWith(file_task_runner);
+ orientation_controller_->InitWith(io_task_runner);
}
virtual ~SystemUIImpl() {
- // Stops file watching now if exists. Waiting until message loop shutdon
- // leads to FilePathWatcher crash.
- orientation_controller_->Shutdown();
}
private:
@@ -40,9 +37,10 @@
} // namespace
// static
-SystemUI* SystemUI::Create(scoped_refptr<base::TaskRunner> file_task_runner) {
- DeviceSocketListener::CreateSocketManager(file_task_runner);
- instance = new SystemUIImpl(file_task_runner);
+SystemUI* SystemUI::Create(
+ scoped_refptr<base::TaskRunner> io_task_runner) {
+ DeviceSocketListener::CreateSocketManager(io_task_runner);
+ instance = new SystemUIImpl(io_task_runner);
return instance;
}
« no previous file with comments | « trunk/src/athena/system/orientation_controller.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698