Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(145)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 466043002: Track when user signs in the profile. (Closed)

Created:
6 years, 4 months ago by Mike Lerman
Modified:
6 years, 4 months ago
CC:
chromium-reviews, asvitkine+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Track when user signs in the profile. Track additional timing stats about signing in users Specifically, track if signin took place during first run, and also track how long since Chrome Install the signin took place. BUG=357693 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=290091

Patch Set 1 #

Total comments: 6

Patch Set 2 : Alexei nits #

Patch Set 3 : Test signin client #

Patch Set 4 : Unit tests #

Patch Set 5 : Rebase #

Patch Set 6 : Another unit test #

Patch Set 7 : Android doesn't track first run within chrome c++ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+100 lines, -3 lines) Patch
M chrome/browser/profiles/gaia_info_update_service_unittest.cc View 1 2 3 4 5 2 chunks +10 lines, -1 line 0 comments Download
M chrome/browser/signin/chrome_signin_client.h View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/signin/chrome_signin_client.cc View 1 2 3 4 5 6 3 chunks +19 lines, -0 lines 0 comments Download
M chrome/browser/signin/signin_manager_unittest.cc View 1 2 3 2 chunks +8 lines, -0 lines 0 comments Download
M components/signin/core/browser/signin_client.h View 1 2 chunks +3 lines, -0 lines 0 comments Download
M components/signin/core/browser/signin_manager.cc View 1 2 3 4 1 chunk +3 lines, -0 lines 0 comments Download
M components/signin/core/browser/signin_metrics.h View 1 2 3 4 2 chunks +5 lines, -0 lines 0 comments Download
M components/signin/core/browser/signin_metrics.cc View 1 2 3 4 1 chunk +11 lines, -0 lines 0 comments Download
M components/signin/core/browser/test_signin_client.h View 1 2 3 2 chunks +9 lines, -2 lines 0 comments Download
M components/signin/core/browser/test_signin_client.cc View 1 2 3 2 chunks +13 lines, -0 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 chunk +17 lines, -0 lines 0 comments Download

Messages

Total messages: 29 (0 generated)
Mike Lerman
Hi Roger and Alexei, Another signin-stats CL for you two. Thanks!
6 years, 4 months ago (2014-08-12 18:10:34 UTC) #1
Roger Tawa OOO till Jul 10th
lgtm
6 years, 4 months ago (2014-08-12 19:38:42 UTC) #2
Alexei Svitkine (slow)
LGTM https://codereview.chromium.org/466043002/diff/20001/components/signin/core/browser/signin_client.h File components/signin/core/browser/signin_client.h (right): https://codereview.chromium.org/466043002/diff/20001/components/signin/core/browser/signin_client.h#newcode91 components/signin/core/browser/signin_client.h:91: Nit: Remove empty line. https://codereview.chromium.org/466043002/diff/20001/components/signin/core/browser/signin_metrics.cc File components/signin/core/browser/signin_metrics.cc (right): ...
6 years, 4 months ago (2014-08-12 19:45:17 UTC) #3
Mike Lerman
Thanks Alexei. https://codereview.chromium.org/466043002/diff/20001/components/signin/core/browser/signin_client.h File components/signin/core/browser/signin_client.h (right): https://codereview.chromium.org/466043002/diff/20001/components/signin/core/browser/signin_client.h#newcode91 components/signin/core/browser/signin_client.h:91: On 2014/08/12 19:45:16, Alexei Svitkine wrote: > ...
6 years, 4 months ago (2014-08-13 15:32:20 UTC) #4
Mike Lerman
The CQ bit was checked by mlerman@chromium.org
6 years, 4 months ago (2014-08-13 15:32:26 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mlerman@chromium.org/466043002/40001
6 years, 4 months ago (2014-08-13 15:33:14 UTC) #6
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_clang_dbg on tryserver.chromium.linux ...
6 years, 4 months ago (2014-08-13 16:17:52 UTC) #7
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-13 16:21:26 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: ios_dbg_simulator on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator/builds/5256) ios_rel_device on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device/builds/5266) ios_rel_device_ninja ...
6 years, 4 months ago (2014-08-13 16:21:27 UTC) #9
Mike Lerman
The CQ bit was checked by mlerman@chromium.org
6 years, 4 months ago (2014-08-13 18:31:00 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mlerman@chromium.org/466043002/60001
6 years, 4 months ago (2014-08-13 18:32:46 UTC) #11
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_clang_dbg on tryserver.chromium.linux ...
6 years, 4 months ago (2014-08-14 05:45:14 UTC) #12
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-14 06:01:44 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: android_clang_dbg on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_clang_dbg/builds/5836)
6 years, 4 months ago (2014-08-14 06:01:45 UTC) #14
Mike Lerman
Hi Roger, Can you take a look at my latest patch? I had to do ...
6 years, 4 months ago (2014-08-14 14:45:08 UTC) #15
Roger Tawa OOO till Jul 10th
still lgtm
6 years, 4 months ago (2014-08-14 15:46:10 UTC) #16
Mike Lerman
The CQ bit was checked by mlerman@chromium.org
6 years, 4 months ago (2014-08-14 15:49:29 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mlerman@chromium.org/466043002/80001
6 years, 4 months ago (2014-08-14 15:52:32 UTC) #18
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_aosp on tryserver.chromium.linux ...
6 years, 4 months ago (2014-08-15 01:46:42 UTC) #19
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-15 02:01:39 UTC) #20
commit-bot: I haz the power
Try jobs failed on following builders: android_clang_dbg on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_clang_dbg/builds/6201) android_dbg on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_dbg/builds/7131)
6 years, 4 months ago (2014-08-15 02:01:40 UTC) #21
Mike Lerman
Hey Monica, Quick review on this unit test change? Thanks! Mike http://cdn.gifbay.com/2013/03/moonwalking_pony-38861.gif
6 years, 4 months ago (2014-08-15 18:42:25 UTC) #22
noms (inactive)
lgtm. will review profiles for ponies.
6 years, 4 months ago (2014-08-15 18:44:11 UTC) #23
Mike Lerman
The CQ bit was checked by mlerman@chromium.org
6 years, 4 months ago (2014-08-15 19:43:18 UTC) #24
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mlerman@chromium.org/466043002/120001
6 years, 4 months ago (2014-08-15 19:45:52 UTC) #25
Mike Lerman
The CQ bit was checked by mlerman@chromium.org
6 years, 4 months ago (2014-08-15 20:49:40 UTC) #26
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mlerman@chromium.org/466043002/140001
6 years, 4 months ago (2014-08-15 20:50:32 UTC) #27
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_dbg_triggered_tests on tryserver.chromium.linux ...
6 years, 4 months ago (2014-08-16 00:25:54 UTC) #28
commit-bot: I haz the power
6 years, 4 months ago (2014-08-16 05:40:26 UTC) #29
Message was sent while issue was closed. 
Committed patchset #7 (140001) as 290091

Powered by Google App Engine
This is Rietveld 408576698