components/signin/core/browser/signin_manager.cc - Issue 466043002: Track when user signs in the profile.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/signin/core/browser/signin_manager.cc

Issue 466043002: Track when user signs in the profile. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Android doesn't track first run within chrome c++ Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/signin/core/browser/signin_manager.cc

diff --git a/components/signin/core/browser/signin_manager.cc b/components/signin/core/browser/signin_manager.cc

index ea1cc06fdf00e2fe5e9f88fb444eda57103d5d0e..7358cbb7fbb8d07d103927613209a7ceb7656a31 100644

--- a/components/signin/core/browser/signin_manager.cc

+++ b/components/signin/core/browser/signin_manager.cc

@@ -377,6 +377,9 @@ void SigninManager::OnSignedIn(const std::string& username) {

client_->GoogleSigninSucceeded(GetAuthenticatedUsername(), password_);

+ signin_metrics::LogSigninProfile(client_->IsFirstRun(),

+ client_->GetInstallDate());

password_.clear(); // Don't need it anymore.

DisableOneClickSignIn(client_->GetPrefs()); // Don't ever offer again.

}