Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3603)

Unified Diff: chrome/browser/profiles/gaia_info_update_service_unittest.cc

Issue 466043002: Track when user signs in the profile. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Android doesn't track first run within chrome c++ Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/signin/chrome_signin_client.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/profiles/gaia_info_update_service_unittest.cc
diff --git a/chrome/browser/profiles/gaia_info_update_service_unittest.cc b/chrome/browser/profiles/gaia_info_update_service_unittest.cc
index ce2f601ab0a020a1eac6a5fd93cc87914ab67556..b4359cfba598a9faeb009d707ac91cb3ed1355a6 100644
--- a/chrome/browser/profiles/gaia_info_update_service_unittest.cc
+++ b/chrome/browser/profiles/gaia_info_update_service_unittest.cc
@@ -7,10 +7,13 @@
#include "base/prefs/pref_service.h"
#include "base/strings/utf_string_conversions.h"
#include "chrome/browser/browser_process.h"
+#include "chrome/browser/prefs/pref_service_syncable.h"
#include "chrome/browser/profiles/profile_downloader.h"
#include "chrome/browser/profiles/profile_info_cache.h"
#include "chrome/browser/profiles/profile_info_cache_unittest.h"
+#include "chrome/browser/signin/chrome_signin_client_factory.h"
#include "chrome/browser/signin/signin_manager_factory.h"
+#include "chrome/browser/signin/test_signin_client_builder.h"
#include "chrome/common/pref_names.h"
#include "chrome/test/base/testing_browser_process.h"
#include "chrome/test/base/testing_profile.h"
@@ -68,7 +71,13 @@ class GAIAInfoUpdateServiceTest : public ProfileInfoCacheTest {
NiceMock<ProfileDownloaderMock>* downloader() { return downloader_.get(); }
Profile* CreateProfile(const std::string& name) {
- Profile* profile = testing_profile_manager_.CreateTestingProfile(name);
+ TestingProfile::TestingFactories testing_factories;
+ testing_factories.push_back(std::make_pair(
+ ChromeSigninClientFactory::GetInstance(),
+ signin::BuildTestSigninClient));
+ Profile* profile = testing_profile_manager_.CreateTestingProfile(name,
+ scoped_ptr<PrefServiceSyncable>(), base::UTF8ToUTF16(name), 0,
+ std::string(), testing_factories);
// The testing manager sets the profile name manually, which counts as
// a user-customized profile name. Reset this to match the default name
// we are actually using.
« no previous file with comments | « no previous file | chrome/browser/signin/chrome_signin_client.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698