Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(423)

Unified Diff: components/signin/core/browser/test_signin_client.h

Issue 466043002: Track when user signs in the profile. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Android doesn't track first run within chrome c++ Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/signin/core/browser/test_signin_client.h
diff --git a/components/signin/core/browser/test_signin_client.h b/components/signin/core/browser/test_signin_client.h
index 18b28a4bb039612c1b23598cb79ef742321609cd..94240a067647fb8a58107aedf9359635cefa06f5 100644
--- a/components/signin/core/browser/test_signin_client.h
+++ b/components/signin/core/browser/test_signin_client.h
@@ -50,9 +50,14 @@ class TestSigninClient : public SigninClient {
// Returns the empty string.
virtual std::string GetProductVersion() OVERRIDE;
- // Returns a TestURLRequestContextGetter.
+ // Returns a TestURLRequestContextGetter or an manually provided
+ // URLRequestContextGetter.
virtual net::URLRequestContextGetter* GetURLRequestContext() OVERRIDE;
+ // For testing purposes, can override the TestURLRequestContextGetter created
+ // in the default constructor.
+ void SetURLRequestContext(net::URLRequestContextGetter* request_context);
+
#if defined(OS_IOS)
virtual ios::ProfileOAuth2TokenServiceIOSProvider* GetIOSProvider() OVERRIDE;
#endif
@@ -73,13 +78,15 @@ class TestSigninClient : public SigninClient {
virtual void ClearSigninProcess() OVERRIDE;
virtual bool IsSigninProcess(int host_id) const OVERRIDE;
virtual bool HasSigninProcess() const OVERRIDE;
+ virtual bool IsFirstRun() const OVERRIDE;
+ virtual base::Time GetInstallDate() OVERRIDE;
private:
// Loads the token database.
void LoadDatabase();
base::ScopedTempDir temp_dir_;
- scoped_refptr<net::TestURLRequestContextGetter> request_context_;
+ scoped_refptr<net::URLRequestContextGetter> request_context_;
scoped_refptr<TokenWebData> database_;
int signin_host_id_;
CookieChangedCallbackList cookie_callbacks_;
« no previous file with comments | « components/signin/core/browser/signin_metrics.cc ('k') | components/signin/core/browser/test_signin_client.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698