Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(207)

Issue 464273003: Restructure handling of list type extended attributes (Closed)

Created:
6 years, 4 months ago by Jens Widell
Modified:
6 years, 4 months ago
Reviewers:
haraken, bashi
CC:
blink-reviews, eae+blinkwatch, fs, eric.carlson_apple.com, apavlov+blink_chromium.org, aandrey+blink_chromium.org, rwlbuis, arv+blink, blink-reviews-css, blink-reviews-html_chromium.org, abarth-chromium, blink-reviews-dom_chromium.org, dglazkov+blink, Rik, blink-reviews-bindings_chromium.org, rune+blink, nessy, sof, feature-media-reviews_chromium.org, darktears, vcarbune.chromium, philipj_slow, gavinp+prerender_chromium.org, gasubic, ed+blinkwatch_opera.com, Inactive
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Restructure handling of list type extended attributes This patch does a number of things: - Drops the [Attr=Some|Other] syntax, in favor of [Attr=(Some,Other)] which WebIDL defines, and converts all uses of the former in our IDL files. Also drops related grammar overrides from blink_idl_parser.py. - Simplifies [Conditional] to only support single identifier form, which is the only way it's used in current (real) IDL files. - Adds [Attr="value"] and [Attr=("some","other")] instead of the previous [Attr="some"|"other"] syntax, to better match the syntax of identifier lists. - Changes the output from the parser to be Python lists for list type attributes, so that the rest of the code doesn't need to do string splitting operations. In the case of string literal values means we can now handle string literals containing ',' and '|' correctly, should that ever become an issue. None of these changes affect code generation. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=180852

Patch Set 1 #

Patch Set 2 : minor fixes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+75 lines, -197 lines) Patch
M Source/bindings/scripts/aggregate_generated_bindings.py View 4 chunks +3 lines, -14 lines 0 comments Download
M Source/bindings/scripts/blink_idl_parser.py View 1 2 chunks +20 lines, -28 lines 0 comments Download
M Source/bindings/scripts/idl_definitions.py View 1 1 chunk +2 lines, -1 line 0 comments Download
M Source/bindings/scripts/idl_validator.py View 1 chunk +3 lines, -1 line 0 comments Download
M Source/bindings/scripts/v8_attributes.py View 2 chunks +4 lines, -3 lines 0 comments Download
M Source/bindings/scripts/v8_interface.py View 2 chunks +4 lines, -2 lines 0 comments Download
M Source/bindings/scripts/v8_utilities.py View 5 chunks +13 lines, -17 lines 0 comments Download
M Source/bindings/tests/idls/TestInterface.idl View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/bindings/tests/idls/TestInterface2.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/tests/idls/TestInterface3.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/tests/idls/TestObject.idl View 3 chunks +7 lines, -10 lines 0 comments Download
M Source/bindings/tests/results/V8TestInterface.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/tests/results/V8TestObject.cpp View 4 chunks +0 lines, -102 lines 0 comments Download
M Source/core/css/CSSStyleDeclaration.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/Document.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/Element.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLFormElement.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLImageElement.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLLinkElement.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLMediaElement.idl View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/html/HTMLScriptElement.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/canvas/CanvasRenderingContext2D.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/canvas/WebGLRenderingContextBase.idl View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/modules/mediasource/MediaSource.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/mediasource/SourceBuffer.idl View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
Jens Widell
WDYT? Worth splitting up and landing? These changes do not cause any CG changes.
6 years, 4 months ago (2014-08-25 10:47:14 UTC) #1
haraken
LGTM. I'm fine with landing this CL in one go. Just to confirm: Is [Attr=(A ...
6 years, 4 months ago (2014-08-25 11:35:16 UTC) #2
Jens Widell
On 2014/08/25 11:35:16, haraken wrote: > LGTM. I'm fine with landing this CL in one ...
6 years, 4 months ago (2014-08-25 11:47:28 UTC) #3
Jens Widell
The CQ bit was checked by jl@opera.com
6 years, 4 months ago (2014-08-25 13:55:47 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jl@opera.com/464273003/20001
6 years, 4 months ago (2014-08-25 13:56:45 UTC) #5
commit-bot: I haz the power
6 years, 4 months ago (2014-08-25 13:59:19 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (20001) as 180852

Powered by Google App Engine
This is Rietveld 408576698