Source/bindings/scripts/idl_validator.py - Issue 464273003: Restructure handling of list type extended attributes

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/scripts/idl_validator.py

Issue 464273003: Restructure handling of list type extended attributes (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: minor fixes Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/bindings/scripts/idl_validator.py

diff --git a/Source/bindings/scripts/idl_validator.py b/Source/bindings/scripts/idl_validator.py

index 29ccd7d55c97664502c949b934b2ddc11748be76..e75099ee2fe45e2b11e922acd6ab451105879762 100644

--- a/Source/bindings/scripts/idl_validator.py

+++ b/Source/bindings/scripts/idl_validator.py

@@ -77,8 +77,10 @@ class IDLExtendedAttributeValidator(object):

return

if values_string is None:

values = set([None])

+ elif isinstance(values_string, list):

+ values = set(values_string)

else:

- values = set(re.split('[|,]', values_string))

+ values = set([values_string])

invalid_values = values - valid_values

if invalid_values:

invalid_value = invalid_values.pop()

« no previous file with comments | « Source/bindings/scripts/idl_definitions.py ('k') | Source/bindings/scripts/v8_attributes.py » ('j') | no next file with comments »