Source/bindings/scripts/v8_interface.py - Issue 464273003: Restructure handling of list type extended attributes

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/scripts/v8_interface.py

Issue 464273003: Restructure handling of list type extended attributes (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: minor fixes Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/bindings/scripts/v8_interface.py

diff --git a/Source/bindings/scripts/v8_interface.py b/Source/bindings/scripts/v8_interface.py

index 3f807e6489af96915b105f5f0f424c9f08301d32..c63a368042f644a5223c366c40462b27171c61c4 100644

--- a/Source/bindings/scripts/v8_interface.py

+++ b/Source/bindings/scripts/v8_interface.py

@@ -46,7 +46,9 @@ import v8_methods

import v8_types

from v8_types import cpp_ptr_type, cpp_template_type

import v8_utilities

-from v8_utilities import capitalize, conditional_string, cpp_name, gc_type, has_extended_attribute_value, runtime_enabled_function_name

+from v8_utilities import (capitalize, conditional_string, cpp_name, gc_type,

+ has_extended_attribute_value, runtime_enabled_function_name,

+ extended_attribute_value_as_list)

INTERFACE_H_INCLUDES = frozenset([

@@ -128,7 +130,7 @@ def interface_context(interface):

# [SpecialWrapFor]

if 'SpecialWrapFor' in extended_attributes:

- special_wrap_for = extended_attributes['SpecialWrapFor'].split('|')

+ special_wrap_for = extended_attribute_value_as_list(interface, 'SpecialWrapFor')

else:

special_wrap_for = []

for special_wrap_interface in special_wrap_for:

« no previous file with comments | « Source/bindings/scripts/v8_attributes.py ('k') | Source/bindings/scripts/v8_utilities.py » ('j') | no next file with comments »