Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(381)

Unified Diff: Source/core/Init.h

Issue 464043002: Refactor module initialization. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | Source/core/Init.cpp » ('j') | Source/modules/InitModules.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/Init.h
diff --git a/Source/core/Init.h b/Source/core/Init.h
index 3579688d5c74865fd0be1d202dbd2ffad5333b9d..3b9e75b86d931dd946dafe67c3e21d8d9880d746 100644
--- a/Source/core/Init.h
+++ b/Source/core/Init.h
@@ -37,17 +37,17 @@ class CoreInitializer {
public:
CoreInitializer() : m_isInited(false) { }
// Should be called by clients before trying to create Frames.
- void init();
-
- virtual void registerEventFactory();
- virtual void initEventNames();
- virtual void initEventTargetNames();
- virtual void initBindings() { }
+ virtual void init();
// FIXME: Why is this function static?
static void shutdown();
private:
+ void registerEventFactory();
+ void initEventNames();
+ void initEventTargetNames();
+
+protected:
bool m_isInited;
abarth-chromium 2014/08/12 21:42:55 Can we make a protected getter and make the actual
cmumford 2014/08/12 22:26:35 Done.
};
« no previous file with comments | « no previous file | Source/core/Init.cpp » ('j') | Source/modules/InitModules.cpp » ('J')

Powered by Google App Engine
This is Rietveld 408576698