Refactor module initialization.

Source/modules/InitModules.cpp

Index: Source/modules/InitModules.cpp
diff --git a/Source/modules/InitModules.cpp b/Source/modules/InitModules.cpp
index b1b14e6a5fcb33e5b9580f7c24e04550a86839ec..329b473d036cbe6c6450c3e3fe3fec98cbbd0204 100644
--- a/Source/modules/InitModules.cpp
+++ b/Source/modules/InitModules.cpp
@@ -14,21 +14,31 @@
 
 namespace blink {
 
+void ModulesInitializer::init()
+{
+    ASSERT(!m_isInited);
+
+    // Strings must be initialized before calling CoreInitializer::init().
+    initEventNames();
+    initEventTargetNames();
+    registerEventFactory();
+    initBindings();
+
+    CoreInitializer::init();
+}

[abarth-chromium, 2014/08/12 21:42:55]

I'd add an ASSERT(m_isInited); at the end of this function.

[cmumford, 2014/08/12 22:26:35]

Done.

+
 void ModulesInitializer::initEventNames()
 {
-    EventNames::init();
     EventNames::initModules();
 }
 
 void ModulesInitializer::initEventTargetNames()
 {
-    EventTargetNames::init();
     EventTargetNames::initModules();
 }
 
 void ModulesInitializer::registerEventFactory()
 {
-    CoreInitializer::registerEventFactory();
     Document::registerEventFactory(EventModulesFactory::create());
 }

[abarth-chromium, 2014/08/12 21:42:55]

Can you inline these functions into their one caller?  It's silly to have them
all be separate functions.

[cmumford, 2014/08/12 22:26:35]

Done. Also took the liberty of doing the same with
CoreInitializer::initEventNames() and CoreInitializer::initEventTargetNames().
Let me know if you prefer the previous implementation.