Source/core/Init.cpp - Issue 464043002: Refactor module initialization. - Code Review

Chromium Code Reviews

chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out

(401)

My Issues | Starred Open | Closed | All

Unified Diff: Source/core/Init.cpp

Issue 464043002: Refactor module initialization. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

« Source/core/Init.h ('K') | « Source/core/Init.h ('k') | Source/modules/InitModules.h » ('j') | Source/modules/InitModules.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/Init.cpp

diff --git a/Source/core/Init.cpp b/Source/core/Init.cpp

index af7c9e1506c20245a48856c202a86bbbb13ee7d2..6f9b75f1b391f9ff80c34a0c521ec522af0c8ba3 100644

--- a/Source/core/Init.cpp

+++ b/Source/core/Init.cpp

@@ -79,8 +79,7 @@ void CoreInitializer::registerEventFactory()

void CoreInitializer::init()

{

- if (m_isInited)

- return;

+ ASSERT(!m_isInited);

m_isInited = true;

// It would make logical sense to do this and WTF::StringStatics::init() in

@@ -108,7 +107,6 @@ void CoreInitializer::init()

Partitions::init();

EventTracer::initialize();

- initBindings();

registerEventFactory();

// Ensure that the main thread's thread-local data is initialized before

« Source/core/Init.h ('K') | « Source/core/Init.h ('k') | Source/modules/InitModules.h » ('j') | Source/modules/InitModules.cpp » ('J')

Powered by Google App Engine

This is Rietveld 408576698