Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(349)

Side by Side Diff: Source/core/Init.h

Issue 464043002: Refactor module initialization. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | Source/core/Init.cpp » ('j') | Source/modules/InitModules.cpp » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2013 Google Inc. All rights reserved. 2 * Copyright (C) 2013 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 19 matching lines...) Expand all
30 30
31 #ifndef Init_h 31 #ifndef Init_h
32 #define Init_h 32 #define Init_h
33 33
34 namespace blink { 34 namespace blink {
35 35
36 class CoreInitializer { 36 class CoreInitializer {
37 public: 37 public:
38 CoreInitializer() : m_isInited(false) { } 38 CoreInitializer() : m_isInited(false) { }
39 // Should be called by clients before trying to create Frames. 39 // Should be called by clients before trying to create Frames.
40 void init(); 40 virtual void init();
41
42 virtual void registerEventFactory();
43 virtual void initEventNames();
44 virtual void initEventTargetNames();
45 virtual void initBindings() { }
46 41
47 // FIXME: Why is this function static? 42 // FIXME: Why is this function static?
48 static void shutdown(); 43 static void shutdown();
49 44
50 private: 45 private:
46 void registerEventFactory();
47 void initEventNames();
48 void initEventTargetNames();
49
50 protected:
51 bool m_isInited; 51 bool m_isInited;
abarth-chromium 2014/08/12 21:42:55 Can we make a protected getter and make the actual
cmumford 2014/08/12 22:26:35 Done.
52 }; 52 };
53 53
54 } // namespace blink 54 } // namespace blink
55 55
56 #endif // Init_h 56 #endif // Init_h
OLDNEW
« no previous file with comments | « no previous file | Source/core/Init.cpp » ('j') | Source/modules/InitModules.cpp » ('J')

Powered by Google App Engine
This is Rietveld 408576698