Refactor module initialization.

Refactor module initialization.

Previous implementation had three CoreInitializer methods: initEventNames,
initEventTargetNames, and initBindings, which were never called, and
ModulesInitializer contained identically named methods which were a
superset of the base class implementation. This change removes duplication
and separates core and modules initialization for a cleaner implementation.

This change doesn't fix 393728, but is a necessary refactoring for the
actual fix.

BUG=393728
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=180130

[cmumford, 2014-08-12 21:35:12]

PTAL.

Downstream CL is https://codereview.chromium.org/426063010/

[abarth-chromium, 2014-08-12 21:42:56]

LGTM

https://codereview.chromium.org/464043002/diff/1/Source/core/Init.h
File Source/core/Init.h (right):

https://codereview.chromium.org/464043002/diff/1/Source/core/Init.h#newcode51
Source/core/Init.h:51: bool m_isInited;
Can we make a protected getter and make the actual member private?

https://codereview.chromium.org/464043002/diff/1/Source/modules/InitModules.cpp
File Source/modules/InitModules.cpp (right):

https://codereview.chromium.org/464043002/diff/1/Source/modules/InitModules.c...
Source/modules/InitModules.cpp:28: }
I'd add an ASSERT(m_isInited); at the end of this function.

https://codereview.chromium.org/464043002/diff/1/Source/modules/InitModules.c...
Source/modules/InitModules.cpp:43: }
Can you inline these functions into their one caller?  It's silly to have them
all be separate functions.

[cmumford, 2014-08-12 22:26:36]

abarth: Being that I made two extra changes, 1) deleting single-line
CoreInitializer methods and 2) deleting createEventModules, would you mind
giving this change one final look?

https://codereview.chromium.org/464043002/diff/1/Source/core/Init.h
File Source/core/Init.h (right):

https://codereview.chromium.org/464043002/diff/1/Source/core/Init.h#newcode51
Source/core/Init.h:51: bool m_isInited;
On 2014/08/12 21:42:55, abarth wrote:
> Can we make a protected getter and make the actual member private?

Done.

https://codereview.chromium.org/464043002/diff/1/Source/modules/InitModules.cpp
File Source/modules/InitModules.cpp (right):

https://codereview.chromium.org/464043002/diff/1/Source/modules/InitModules.c...
Source/modules/InitModules.cpp:28: }
On 2014/08/12 21:42:55, abarth wrote:
> I'd add an ASSERT(m_isInited); at the end of this function.

Done.

https://codereview.chromium.org/464043002/diff/1/Source/modules/InitModules.c...
Source/modules/InitModules.cpp:43: }
On 2014/08/12 21:42:55, abarth wrote:
> Can you inline these functions into their one caller?  It's silly to have them
> all be separate functions.

Done. Also took the liberty of doing the same with
CoreInitializer::initEventNames() and CoreInitializer::initEventTargetNames().
Let me know if you prefer the previous implementation.

https://codereview.chromium.org/464043002/diff/20001/Source/modules/InitModul...
File Source/modules/InitModules.h (left):

https://codereview.chromium.org/464043002/diff/20001/Source/modules/InitModul...
Source/modules/InitModules.h:24: PassRefPtrWillBeRawPtr<Event>
createEventModules(const String& eventType, ExceptionState&);
It looks like createEventModules was deleted in r175179 when moving to
registerEventFactory and should have been deleted then.

[abarth-chromium, 2014-08-12 23:36:16]

Looks great!  LGTM.  Thanks!

[cmumford, 2014-08-12 23:50:41]

The CQ bit was checked by cmumford@chromium.org

[commit-bot: I haz the power, 2014-08-12 23:52:30]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/cmumford@chromium.org/464043002/20001

[commit-bot: I haz the power, 2014-08-13 00:51:11]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  mac_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/mac_blink_rel/builds/19543)

[commit-bot: I haz the power, 2014-08-13 01:21:34]

Change committed as 180130