Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(289)

Unified Diff: Source/core/Init.cpp

Issue 464043002: Refactor module initialization. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Removed one-line functions and added isInitialized Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/Init.cpp
diff --git a/Source/core/Init.cpp b/Source/core/Init.cpp
index af7c9e1506c20245a48856c202a86bbbb13ee7d2..a6e5b8ad37f34ad27da49c0cbb5b95af898472e0 100644
--- a/Source/core/Init.cpp
+++ b/Source/core/Init.cpp
@@ -57,16 +57,6 @@
namespace blink {
-void CoreInitializer::initEventNames()
-{
- EventNames::init();
-}
-
-void CoreInitializer::initEventTargetNames()
-{
- EventTargetNames::init();
-}
-
void CoreInitializer::registerEventFactory()
{
static bool isRegistered = false;
@@ -79,8 +69,7 @@ void CoreInitializer::registerEventFactory()
void CoreInitializer::init()
{
- if (m_isInited)
- return;
+ ASSERT(!m_isInited);
m_isInited = true;
// It would make logical sense to do this and WTF::StringStatics::init() in
@@ -93,8 +82,8 @@ void CoreInitializer::init()
XMLNSNames::init();
XMLNames::init();
- initEventNames();
- initEventTargetNames();
+ EventNames::init();
+ EventTargetNames::init();
EventTypeNames::init();
FetchInitiatorTypeNames::init();
FontFamilyNames::init();
@@ -108,7 +97,6 @@ void CoreInitializer::init()
Partitions::init();
EventTracer::initialize();
- initBindings();
registerEventFactory();
// Ensure that the main thread's thread-local data is initialized before
« no previous file with comments | « Source/core/Init.h ('k') | Source/modules/InitModules.h » ('j') | Source/modules/InitModules.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698