Refactor module initialization.

Source/modules/InitModules.cpp

 // Copyright (c) 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "config.h"
 #include "InitModules.h"
 
 #include "bindings/modules/v8/ModuleBindingsInitializer.h"
 #include "core/EventTypeNames.h"
 #include "core/dom/Document.h"
 #include "modules/EventModulesFactory.h"
 #include "modules/EventModulesNames.h"
 #include "modules/EventTargetModulesNames.h"
 
 namespace blink {
 
+void ModulesInitializer::init()
+{
+    ASSERT(!m_isInited);
+
+    // Strings must be initialized before calling CoreInitializer::init().
+    initEventNames();
+    initEventTargetNames();
+    registerEventFactory();
+    initBindings();
+
+    CoreInitializer::init();
+}

[abarth-chromium, 2014/08/12 21:42:55]

I'd add an ASSERT(m_isInited); at the end of this function.

[cmumford, 2014/08/12 22:26:35]

Done.

+
 void ModulesInitializer::initEventNames()
 {
-    EventNames::init();
     EventNames::initModules();
 }
 
 void ModulesInitializer::initEventTargetNames()
 {
-    EventTargetNames::init();
     EventTargetNames::initModules();
 }
 
 void ModulesInitializer::registerEventFactory()
 {
-    CoreInitializer::registerEventFactory();
     Document::registerEventFactory(EventModulesFactory::create());
 }

[abarth-chromium, 2014/08/12 21:42:55]

Can you inline these functions into their one caller?  It's silly to have them
all be separate functions.

[cmumford, 2014/08/12 22:26:35]

Done. Also took the liberty of doing the same with
CoreInitializer::initEventNames() and CoreInitializer::initEventTargetNames().
Let me know if you prefer the previous implementation.

 
 void ModulesInitializer::initBindings()
 {
     ModuleBindingsInitializer::init();
 }
 
 } // namespace blink