Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 463563003: CastContentBrowserClient should not hold CastBrowserMainParts lifetime. (Closed)

Created:
6 years, 4 months ago by gunsch
Modified:
6 years, 4 months ago
Reviewers:
lcwu1, byungchul
CC:
chromium-reviews, ozone-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

CastContentBrowserClient should not hold CastBrowserMainParts lifetime. R=lcwu@chromium.org,byungchul@chromium.org BUG=None Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=289241

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -6 lines) Patch
M chromecast/chromecast.gyp View 1 chunk +1 line, -1 line 0 comments Download
M chromecast/shell/browser/cast_content_browser_client.h View 2 chunks +4 lines, -2 lines 0 comments Download
M chromecast/shell/browser/cast_content_browser_client.cc View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
gunsch
6 years, 4 months ago (2014-08-11 17:31:35 UTC) #1
byungchul
lgtm
6 years, 4 months ago (2014-08-12 20:14:36 UTC) #2
gunsch
The CQ bit was checked by gunsch@chromium.org
6 years, 4 months ago (2014-08-13 00:16:14 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gunsch@chromium.org/463563003/1
6 years, 4 months ago (2014-08-13 00:47:23 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-13 00:47:24 UTC) #5
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 4 months ago (2014-08-13 00:47:26 UTC) #6
lcwu1
lgtm
6 years, 4 months ago (2014-08-13 00:50:42 UTC) #7
gunsch
The CQ bit was checked by gunsch@chromium.org
6 years, 4 months ago (2014-08-13 00:52:45 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gunsch@chromium.org/463563003/1
6 years, 4 months ago (2014-08-13 01:07:53 UTC) #9
commit-bot: I haz the power
6 years, 4 months ago (2014-08-13 09:56:13 UTC) #10
Message was sent while issue was closed. 
Change committed as 289241

Powered by Google App Engine
This is Rietveld 408576698