Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(133)

Side by Side Diff: chromecast/shell/browser/cast_content_browser_client.cc

Issue 463563003: CastContentBrowserClient should not hold CastBrowserMainParts lifetime. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chromecast/shell/browser/cast_content_browser_client.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chromecast/shell/browser/cast_content_browser_client.h" 5 #include "chromecast/shell/browser/cast_content_browser_client.h"
6 6
7 #include "base/command_line.h" 7 #include "base/command_line.h"
8 #include "chromecast/shell/browser/cast_browser_context.h" 8 #include "chromecast/shell/browser/cast_browser_context.h"
9 #include "chromecast/shell/browser/cast_browser_main_parts.h" 9 #include "chromecast/shell/browser/cast_browser_main_parts.h"
10 #include "chromecast/shell/browser/geolocation/cast_access_token_store.h" 10 #include "chromecast/shell/browser/geolocation/cast_access_token_store.h"
(...skipping 10 matching lines...) Expand all
21 21
22 CastContentBrowserClient::CastContentBrowserClient() 22 CastContentBrowserClient::CastContentBrowserClient()
23 : url_request_context_factory_(new URLRequestContextFactory()) { 23 : url_request_context_factory_(new URLRequestContextFactory()) {
24 } 24 }
25 25
26 CastContentBrowserClient::~CastContentBrowserClient() { 26 CastContentBrowserClient::~CastContentBrowserClient() {
27 } 27 }
28 28
29 content::BrowserMainParts* CastContentBrowserClient::CreateBrowserMainParts( 29 content::BrowserMainParts* CastContentBrowserClient::CreateBrowserMainParts(
30 const content::MainFunctionParams& parameters) { 30 const content::MainFunctionParams& parameters) {
31 shell_browser_main_parts_.reset( 31 shell_browser_main_parts_ =
32 new CastBrowserMainParts(parameters, url_request_context_factory_.get())); 32 new CastBrowserMainParts(parameters, url_request_context_factory_.get());
33 return shell_browser_main_parts_.get(); 33 return shell_browser_main_parts_;
34 } 34 }
35 35
36 void CastContentBrowserClient::RenderProcessWillLaunch( 36 void CastContentBrowserClient::RenderProcessWillLaunch(
37 content::RenderProcessHost* host) { 37 content::RenderProcessHost* host) {
38 } 38 }
39 39
40 net::URLRequestContextGetter* CastContentBrowserClient::CreateRequestContext( 40 net::URLRequestContextGetter* CastContentBrowserClient::CreateRequestContext(
41 content::BrowserContext* browser_context, 41 content::BrowserContext* browser_context,
42 content::ProtocolHandlerMap* protocol_handlers, 42 content::ProtocolHandlerMap* protocol_handlers,
43 content::URLRequestInterceptorScopedVector request_interceptors) { 43 content::URLRequestInterceptorScopedVector request_interceptors) {
(...skipping 93 matching lines...) Expand 10 before | Expand all | Expand 10 after
137 } 137 }
138 138
139 void CastContentBrowserClient::GetAdditionalMappedFilesForChildProcess( 139 void CastContentBrowserClient::GetAdditionalMappedFilesForChildProcess(
140 const base::CommandLine& command_line, 140 const base::CommandLine& command_line,
141 int child_process_id, 141 int child_process_id,
142 std::vector<content::FileDescriptorInfo>* mappings) { 142 std::vector<content::FileDescriptorInfo>* mappings) {
143 } 143 }
144 144
145 } // namespace shell 145 } // namespace shell
146 } // namespace chromecast 146 } // namespace chromecast
OLDNEW
« no previous file with comments | « chromecast/shell/browser/cast_content_browser_client.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698