chromecast/shell/browser/cast_content_browser_client.cc - Issue 463563003: CastContentBrowserClient should not hold CastBrowserMainParts lifetime.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chromecast/shell/browser/cast_content_browser_client.cc

Issue 463563003: CastContentBrowserClient should not hold CastBrowserMainParts lifetime. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chromecast/shell/browser/cast_content_browser_client.cc

diff --git a/chromecast/shell/browser/cast_content_browser_client.cc b/chromecast/shell/browser/cast_content_browser_client.cc

index fc1dac87b767548f0bfa6cee7b23abc6b76bca51..ccf8e217bffd88392e1bdf7e0dd633f8bcb0c2e5 100644

--- a/chromecast/shell/browser/cast_content_browser_client.cc

+++ b/chromecast/shell/browser/cast_content_browser_client.cc

@@ -28,9 +28,9 @@ CastContentBrowserClient::~CastContentBrowserClient() {

content::BrowserMainParts* CastContentBrowserClient::CreateBrowserMainParts(

const content::MainFunctionParams& parameters) {

- shell_browser_main_parts_.reset(

- new CastBrowserMainParts(parameters, url_request_context_factory_.get()));

- return shell_browser_main_parts_.get();

+ shell_browser_main_parts_ =

+ new CastBrowserMainParts(parameters, url_request_context_factory_.get());

+ return shell_browser_main_parts_;

}

void CastContentBrowserClient::RenderProcessWillLaunch(

« no previous file with comments | « chromecast/shell/browser/cast_content_browser_client.h ('k') | no next file » | no next file with comments »