Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(870)

Side by Side Diff: chromecast/shell/browser/cast_content_browser_client.h

Issue 463563003: CastContentBrowserClient should not hold CastBrowserMainParts lifetime. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chromecast/chromecast.gyp ('k') | chromecast/shell/browser/cast_content_browser_client.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROMECAST_SHELL_BROWSER_CAST_CONTENT_BROWSER_CLIENT_H_ 5 #ifndef CHROMECAST_SHELL_BROWSER_CAST_CONTENT_BROWSER_CLIENT_H_
6 #define CHROMECAST_SHELL_BROWSER_CAST_CONTENT_BROWSER_CLIENT_H_ 6 #define CHROMECAST_SHELL_BROWSER_CAST_CONTENT_BROWSER_CLIENT_H_
7 7
8 #include "base/macros.h" 8 #include "base/macros.h"
9 #include "base/memory/scoped_ptr.h"
9 #include "content/public/browser/content_browser_client.h" 10 #include "content/public/browser/content_browser_client.h"
10 11
11 namespace chromecast { 12 namespace chromecast {
12 namespace shell { 13 namespace shell {
13 14
14 class CastBrowserMainParts; 15 class CastBrowserMainParts;
15 class URLRequestContextFactory; 16 class URLRequestContextFactory;
16 17
17 class CastContentBrowserClient: public content::ContentBrowserClient { 18 class CastContentBrowserClient: public content::ContentBrowserClient {
18 public: 19 public:
(...skipping 43 matching lines...) Expand 10 before | Expand all | Expand 10 after
62 content::ResourceContext* context, 63 content::ResourceContext* context,
63 int render_process_id, 64 int render_process_id,
64 int opener_id, 65 int opener_id,
65 bool* no_javascript_access) OVERRIDE; 66 bool* no_javascript_access) OVERRIDE;
66 virtual void GetAdditionalMappedFilesForChildProcess( 67 virtual void GetAdditionalMappedFilesForChildProcess(
67 const base::CommandLine& command_line, 68 const base::CommandLine& command_line,
68 int child_process_id, 69 int child_process_id,
69 std::vector<content::FileDescriptorInfo>* mappings) OVERRIDE; 70 std::vector<content::FileDescriptorInfo>* mappings) OVERRIDE;
70 71
71 private: 72 private:
72 scoped_ptr<CastBrowserMainParts> shell_browser_main_parts_; 73 // Note: BrowserMainLoop holds ownership of CastBrowserMainParts after it is
73 74 // created.
75 CastBrowserMainParts* shell_browser_main_parts_;
74 scoped_ptr<URLRequestContextFactory> url_request_context_factory_; 76 scoped_ptr<URLRequestContextFactory> url_request_context_factory_;
75 77
76 DISALLOW_COPY_AND_ASSIGN(CastContentBrowserClient); 78 DISALLOW_COPY_AND_ASSIGN(CastContentBrowserClient);
77 }; 79 };
78 80
79 } // namespace shell 81 } // namespace shell
80 } // namespace chromecast 82 } // namespace chromecast
81 83
82 #endif // CHROMECAST_SHELL_BROWSER_CAST_CONTENT_BROWSER_CLIENT_H_ 84 #endif // CHROMECAST_SHELL_BROWSER_CAST_CONTENT_BROWSER_CLIENT_H_
OLDNEW
« no previous file with comments | « chromecast/chromecast.gyp ('k') | chromecast/shell/browser/cast_content_browser_client.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698