Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(136)

Issue 462253003: Remove early returns in fullscreen tests (Closed)

Created:
6 years, 4 months ago by philipj_slow
Modified:
6 years, 4 months ago
Reviewers:
falken
CC:
blink-reviews, shans, rjwright, Mike Lawther (Google), blink-reviews-animation_chromium.org, dstockwell, Timothy Loh, darktears, Steve Block, Eric Willigers
Project:
blink
Visibility:
Public.

Description

Remove early returns in fullscreen tests These checks make the tests longer and don't seem particularly useful. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=180256

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+495 lines, -670 lines) Patch
M LayoutTests/fullscreen/anonymous-block-merge-crash.html View 2 chunks +0 lines, -3 lines 0 comments Download
M LayoutTests/fullscreen/empty-anonymous-block-continuation-crash.html View 1 chunk +10 lines, -12 lines 0 comments Download
M LayoutTests/fullscreen/full-screen-cancel.html View 1 chunk +27 lines, -33 lines 0 comments Download
M LayoutTests/fullscreen/full-screen-cancel-nested.html View 1 chunk +28 lines, -34 lines 0 comments Download
M LayoutTests/fullscreen/full-screen-child-not-allowed-crash.html View 1 chunk +1 line, -7 lines 0 comments Download
M LayoutTests/fullscreen/full-screen-crash-offsetLeft.html View 1 chunk +14 lines, -19 lines 0 comments Download
M LayoutTests/fullscreen/full-screen-css.html View 1 1 chunk +28 lines, -34 lines 0 comments Download
M LayoutTests/fullscreen/full-screen-exit-when-popup.html View 1 chunk +25 lines, -31 lines 0 comments Download
M LayoutTests/fullscreen/full-screen-fixed-pos-parent.html View 1 chunk +1 line, -2 lines 0 comments Download
M LayoutTests/fullscreen/full-screen-iframe-zIndex.html View 1 chunk +4 lines, -10 lines 0 comments Download
M LayoutTests/fullscreen/full-screen-keyboard-disabled.html View 1 chunk +24 lines, -30 lines 0 comments Download
M LayoutTests/fullscreen/full-screen-keyboard-enabled.html View 1 chunk +22 lines, -28 lines 0 comments Download
M LayoutTests/fullscreen/full-screen-line-boxes-crash.html View 1 chunk +12 lines, -17 lines 0 comments Download
M LayoutTests/fullscreen/full-screen-no-style-sharing.html View 1 chunk +2 lines, -8 lines 0 comments Download
M LayoutTests/fullscreen/full-screen-placeholder.html View 1 chunk +24 lines, -30 lines 0 comments Download
M LayoutTests/fullscreen/full-screen-remove.html View 1 chunk +23 lines, -29 lines 0 comments Download
M LayoutTests/fullscreen/full-screen-remove-ancestor.html View 1 chunk +21 lines, -27 lines 0 comments Download
M LayoutTests/fullscreen/full-screen-remove-ancestor-after.html View 1 chunk +26 lines, -32 lines 0 comments Download
M LayoutTests/fullscreen/full-screen-remove-ancestor-during-transition.html View 1 chunk +1 line, -6 lines 0 comments Download
M LayoutTests/fullscreen/full-screen-remove-children.html View 1 chunk +21 lines, -27 lines 0 comments Download
M LayoutTests/fullscreen/full-screen-remove-sibling.html View 2 chunks +0 lines, -6 lines 0 comments Download
M LayoutTests/fullscreen/full-screen-render-inline.html View 1 chunk +22 lines, -24 lines 0 comments Download
M LayoutTests/fullscreen/full-screen-request.html View 1 chunk +2 lines, -8 lines 0 comments Download
M LayoutTests/fullscreen/full-screen-request-rejected.html View 1 chunk +8 lines, -14 lines 0 comments Download
M LayoutTests/fullscreen/full-screen-restrictions.html View 1 chunk +47 lines, -53 lines 0 comments Download
M LayoutTests/fullscreen/full-screen-stacking-context.html View 1 chunk +2 lines, -8 lines 0 comments Download
M LayoutTests/fullscreen/full-screen-twice.html View 1 1 chunk +8 lines, -14 lines 0 comments Download
M LayoutTests/fullscreen/full-screen-twice-newapi.html View 1 chunk +32 lines, -38 lines 0 comments Download
M LayoutTests/fullscreen/full-screen-with-flex-item.html View 1 chunk +21 lines, -27 lines 0 comments Download
M LayoutTests/fullscreen/full-screen-zIndex.html View 1 chunk +2 lines, -8 lines 0 comments Download
M LayoutTests/fullscreen/full-screen-zIndex-after.html View 1 chunk +7 lines, -13 lines 0 comments Download
M LayoutTests/fullscreen/parent-flow-inline-with-block-child.html View 1 chunk +28 lines, -30 lines 0 comments Download
M LayoutTests/fullscreen/video-specified-size.html View 1 chunk +2 lines, -8 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
philipj_slow
PTAL. This will obviously conflict with my other CLs, but I'll resolve the conflicts depending ...
6 years, 4 months ago (2014-08-13 09:16:01 UTC) #1
falken
On 2014/08/13 09:16:01, philipj wrote: > PTAL. This will obviously conflict with my other CLs, ...
6 years, 4 months ago (2014-08-14 02:09:54 UTC) #2
philipj_slow
rebase
6 years, 4 months ago (2014-08-14 07:16:10 UTC) #3
philipj_slow
The CQ bit was checked by philipj@opera.com
6 years, 4 months ago (2014-08-14 07:17:39 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/philipj@opera.com/462253003/20001
6 years, 4 months ago (2014-08-14 07:19:00 UTC) #5
philipj_slow
On 2014/08/14 02:09:54, falken wrote: > On 2014/08/13 09:16:01, philipj wrote: > > PTAL. This ...
6 years, 4 months ago (2014-08-14 07:20:02 UTC) #6
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_blink_dbg on tryserver.blink ...
6 years, 4 months ago (2014-08-14 11:19:02 UTC) #7
commit-bot: I haz the power
6 years, 4 months ago (2014-08-14 14:26:24 UTC) #8
Message was sent while issue was closed.
Committed patchset #2 (20001) as 180256

Powered by Google App Engine
This is Rietveld 408576698