Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Unified Diff: LayoutTests/fullscreen/full-screen-line-boxes-crash.html

Issue 462253003: Remove early returns in fullscreen tests (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: rebase Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: LayoutTests/fullscreen/full-screen-line-boxes-crash.html
diff --git a/LayoutTests/fullscreen/full-screen-line-boxes-crash.html b/LayoutTests/fullscreen/full-screen-line-boxes-crash.html
index fc5865f1868730273cf7dedc0277b86409cf3764..7b46f4514f364d5eff1d54be8df2c73930015e09 100644
--- a/LayoutTests/fullscreen/full-screen-line-boxes-crash.html
+++ b/LayoutTests/fullscreen/full-screen-line-boxes-crash.html
@@ -6,24 +6,19 @@ PASS.
<span style="margin-top: 1em;">WebKit didn't crash.
<script src="full-screen-test.js"></script>
<script>
- if (Element.prototype.webkitRequestFullScreen == undefined) {
- logResult(false, "Element.prototype.webkitRequestFullScreen == undefined");
- endTest();
- } else {
- var fullscreenChanged = function(event)
- {
- callback(event)
- };
- waitForEventOnce(document, "webkitfullscreenchange", fullscreenChanged);
- var span = document.getElementsByTagName('span')[0];
- var spanEnteredFullScreen = function() {
- runWithKeyDown(function() { document.documentElement.webkitRequestFullScreen(); });
- setTimeout("endTest()", 0);
- };
+ var fullscreenChanged = function(event)
+ {
+ callback(event)
+ };
+ waitForEventOnce(document, "webkitfullscreenchange", fullscreenChanged);
+ var span = document.getElementsByTagName('span')[0];
+ var spanEnteredFullScreen = function() {
+ runWithKeyDown(function() { document.documentElement.webkitRequestFullScreen(); });
+ setTimeout("endTest()", 0);
+ };
- callback = spanEnteredFullScreen;
- runWithKeyDown(function() { span.webkitRequestFullScreen(); });
- }
+ callback = spanEnteredFullScreen;
+ runWithKeyDown(function() { span.webkitRequestFullScreen(); });
</script>
</body>
</html>
« no previous file with comments | « LayoutTests/fullscreen/full-screen-keyboard-enabled.html ('k') | LayoutTests/fullscreen/full-screen-no-style-sharing.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698