Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(169)

Unified Diff: LayoutTests/fullscreen/full-screen-exit-when-popup.html

Issue 462253003: Remove early returns in fullscreen tests (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: rebase Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: LayoutTests/fullscreen/full-screen-exit-when-popup.html
diff --git a/LayoutTests/fullscreen/full-screen-exit-when-popup.html b/LayoutTests/fullscreen/full-screen-exit-when-popup.html
index f21e98164ebd8b40ecf2845df608db9dce12cb16..a4b0621b6ba5a996ce67b8c79fb11ec25d7a7ae9 100644
--- a/LayoutTests/fullscreen/full-screen-exit-when-popup.html
+++ b/LayoutTests/fullscreen/full-screen-exit-when-popup.html
@@ -2,39 +2,33 @@
<script src="full-screen-test.js"></script>
<span></span>
<script>
- // Bail out early if the full screen API is not enabled or is missing:
- if (Element.prototype.webkitRequestFullScreen == undefined) {
- logResult(false, "Element.prototype.webkitRequestFullScreen == undefined");
- endTest();
- } else {
- if (window.testRunner) {
- testRunner.setCanOpenWindows(true);
- testRunner.setCloseRemainingWindowsWhenComplete(true);
- }
- var callback;
- var fullscreenChanged = function(event)
- {
- if (callback)
- callback(event)
- };
- waitForEvent(document, 'webkitfullscreenchange', fullscreenChanged);
+ if (window.testRunner) {
+ testRunner.setCanOpenWindows(true);
+ testRunner.setCloseRemainingWindowsWhenComplete(true);
+ }
+ var callback;
+ var fullscreenChanged = function(event)
+ {
+ if (callback)
+ callback(event)
+ };
+ waitForEvent(document, 'webkitfullscreenchange', fullscreenChanged);
- var spanEnteredFullScreen = function() {
- testExpected("document.webkitIsFullScreen", true);
- testExpected("document.webkitCurrentFullScreenElement", span);
- callback = cancelledFullScreen;
- testExpected("window.open('about:blank')", null, "!=");
- };
+ var spanEnteredFullScreen = function() {
+ testExpected("document.webkitIsFullScreen", true);
+ testExpected("document.webkitCurrentFullScreenElement", span);
+ callback = cancelledFullScreen;
+ testExpected("window.open('about:blank')", null, "!=");
+ };
- var cancelledFullScreen = function() {
- testExpected("document.webkitIsFullScreen", false);
- testExpected("document.webkitCurrentFullScreenElement", undefined);
- endTest();
- };
+ var cancelledFullScreen = function() {
+ testExpected("document.webkitIsFullScreen", false);
+ testExpected("document.webkitCurrentFullScreenElement", undefined);
+ endTest();
+ };
- var span = document.getElementsByTagName('span')[0];
+ var span = document.getElementsByTagName('span')[0];
- callback = spanEnteredFullScreen;
- runWithKeyDown(function(){span.webkitRequestFullScreen()});
- }
+ callback = spanEnteredFullScreen;
+ runWithKeyDown(function(){span.webkitRequestFullScreen()});
</script>
« no previous file with comments | « LayoutTests/fullscreen/full-screen-css.html ('k') | LayoutTests/fullscreen/full-screen-fixed-pos-parent.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698