Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(173)

Unified Diff: LayoutTests/fullscreen/full-screen-crash-offsetLeft.html

Issue 462253003: Remove early returns in fullscreen tests (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: rebase Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: LayoutTests/fullscreen/full-screen-crash-offsetLeft.html
diff --git a/LayoutTests/fullscreen/full-screen-crash-offsetLeft.html b/LayoutTests/fullscreen/full-screen-crash-offsetLeft.html
index 69a7f9eff9092268b19ee130c466756a17c31b9f..fe2fa8f0f9ba3c5433477f52df838e7d75897d31 100644
--- a/LayoutTests/fullscreen/full-screen-crash-offsetLeft.html
+++ b/LayoutTests/fullscreen/full-screen-crash-offsetLeft.html
@@ -5,27 +5,22 @@
<p><a href="https://bugs.webkit.org/show_bug.cgi?id=89785">Bug 89785</a>: REGRESSION(r116446): Crash in RenderBoxModelObject::adjustedPositionRelativeToOffsetParent</p>
<script src="full-screen-test.js"></script>
<script>
- if ("webkitRequestFullScreen" in Element.prototype) {
- if (!window.testRunner)
- consoleWrite("To manually test this bug, switch to fullscreen. It shouldn't crash.");
+ if (!window.testRunner)
+ consoleWrite("To manually test this bug, switch to fullscreen. It shouldn't crash.");
- video = document.getElementsByTagName("video")[0];
- var fullscreenChanged = function(event)
- {
- video.offsetLeft;
- video.offsetTop;
- consoleWrite("PASSED, the page didn't crash.");
- endTest();
- };
- document.addEventListener('webkitfullscreenchange', fullscreenChanged);
-
- runWithKeyDown(function () {
- video.webkitRequestFullScreen();
- });
- } else {
- consoleWrite("FAILED, couldn't find webkitRequestFullScreen.");
+ video = document.getElementsByTagName("video")[0];
+ var fullscreenChanged = function(event)
+ {
+ video.offsetLeft;
+ video.offsetTop;
+ consoleWrite("PASSED, the page didn't crash.");
endTest();
- }
+ };
+ document.addEventListener('webkitfullscreenchange', fullscreenChanged);
+
+ runWithKeyDown(function () {
+ video.webkitRequestFullScreen();
+ });
</script>
</body>
</html>
« no previous file with comments | « LayoutTests/fullscreen/full-screen-child-not-allowed-crash.html ('k') | LayoutTests/fullscreen/full-screen-css.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698